[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1250: MINIFICPP-1663 Create FetchAzureBlobStorage processor

[GitBox <gi...@apache.org>]

szaszm commented on a change in pull request #1250:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1250#discussion_r790792930



##########
File path: extensions/azure/processors/FetchAzureBlobStorage.cpp
##########
@@ -0,0 +1,118 @@
+/**
+ * @file FetchAzureBlobStorage.cpp
+ * FetchAzureBlobStorage class implementation
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include "FetchAzureBlobStorage.h"
+
+#include "core/Resource.h"
+#include "utils/ProcessorConfigUtils.h"
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+const core::Property FetchAzureBlobStorage::RangeStart(
+  core::PropertyBuilder::createProperty("Range Start")
+    ->withDescription("The byte position at which to start reading from the blob. An empty value or a value of zero will start reading at the beginning of the blob.")
+    ->supportsExpressionLanguage(true)
+    ->build());
+const core::Property FetchAzureBlobStorage::RangeLength(
+  core::PropertyBuilder::createProperty("Range Length")
+    ->withDescription("The number of bytes to download from the blob, starting from the Range Start. "
+                      "An empty value or a value that extends beyond the end of the blob will read to the end of the blob.")
+    ->supportsExpressionLanguage(true)
+    ->build());
+
+const core::Relationship FetchAzureBlobStorage::Success("success", "All successfully processed FlowFiles are routed to this relationship");
+const core::Relationship FetchAzureBlobStorage::Failure("failure", "Unsuccessful operations will be transferred to the failure relationship");
+
+void FetchAzureBlobStorage::initialize() {
+  // Set the supported properties

Review comment:
       Consider removing these comments, because they say the same as the code below them.

##########
File path: docker/test/integration/features/azure_storage.feature
##########
@@ -58,3 +58,21 @@ Feature: Sending data from MiNiFi-C++ to an Azure storage server
     And test blob "test" is created on Azure blob storage with a snapshot
 
     Then the blob and snapshot count becomes 1 in 30 seconds
+
+  Scenario: A MiNiFi instance can fetch a blob from Azure blob storage
+    Given a GetFile processor with the "Input Directory" property set to "/tmp/input"
+    And the "Keep Source File" property of the GetFile processor is set to "true"
+    And a file with the content "dummy" is present in "/tmp/input"
+    And a FetchAzureBlobStorage processor set up to communicate with an Azure blob storage
+    And the "Blob" property of the FetchAzureBlobStorage processor is set to "test"
+    And the "Range Start" property of the FetchAzureBlobStorage processor is set to "6"
+    And the "Range Length" property of the FetchAzureBlobStorage processor is set to "5"
+    And a PutFile processor with the "Directory" property set to "/tmp/output"
+    And the "success" relationship of the GetFile processor is connected to the FetchAzureBlobStorage
+    And the "success" relationship of the FetchAzureBlobStorage processor is connected to the PutFile
+    And an Azure storage server is set up
+
+    When all instances start up
+    And test blob "test" with the content "#test_data$123$#" is created on Azure blob storage
+
+    Then a flowfile with the content "data$" is placed in the monitored directory in less than 60 seconds

Review comment:
       Why isn't it `#test_data$123$#` in the assertion?

##########
File path: extensions/azure/processors/FetchAzureBlobStorage.h
##########
@@ -0,0 +1,100 @@
+/**
+ * @file FetchAzureBlobStorage.h
+ * FetchAzureBlobStorage class declaration
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#pragma once
+
+#include <memory>
+#include <optional>
+#include <string>
+#include <utility>
+#include <vector>
+
+#include "core/Property.h"
+#include "AzureBlobStorageProcessorBase.h"
+#include "core/logging/LoggerConfiguration.h"
+
+template<typename T>
+class AzureBlobStorageTestsFixture;
+
+namespace org::apache::nifi::minifi::azure::processors {
+
+class FetchAzureBlobStorage final : public AzureBlobStorageProcessorBase {
+ public:
+  // Supported Properties
+  EXTENSIONAPI static const core::Property RangeStart;
+  EXTENSIONAPI static const core::Property RangeLength;
+
+  // Supported Relationships
+  static const core::Relationship Failure;
+  static const core::Relationship Success;
+
+  explicit FetchAzureBlobStorage(const std::string& name, const minifi::utils::Identifier& uuid = minifi::utils::Identifier())
+    : FetchAzureBlobStorage(name, uuid, nullptr) {
+  }
+
+  void initialize() override;
+  void onTrigger(const std::shared_ptr<core::ProcessContext> &context, const std::shared_ptr<core::ProcessSession> &session) override;
+
+ private:
+  friend class ::AzureBlobStorageTestsFixture<FetchAzureBlobStorage>;
+
+  class WriteCallback : public OutputStreamCallback {
+   public:

Review comment:
       Consider hiding the callback class in the .cpp file, in an anonymous namespace.

##########
File path: extensions/azure/storage/AzureBlobStorageClient.h
##########
@@ -38,8 +39,27 @@ class AzureBlobStorageClient : public BlobStorageClient {
   Azure::Storage::Blobs::Models::UploadBlockBlobResult uploadBlob(const PutAzureBlobStorageParameters& params, gsl::span<const uint8_t> buffer) override;
   std::string getUrl(const PutAzureBlobStorageParameters& params) override;
   bool deleteBlob(const DeleteAzureBlobStorageParameters& params) override;
+  std::unique_ptr<io::InputStream> fetchBlob(const FetchAzureBlobStorageParameters& params) override;
 
  private:
+  class AzureBlobStorageInputStream : public io::InputStream {
+   public:

Review comment:
       Consider moving this to the .cpp file as an implementation detail, possibly in an anonymous namespace. It's only ever exposed through a base class reference.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org