You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/04/06 12:10:00 UTC
[GitHub] [cloudstack] harikrishna-patnala opened a new pull request, #6202: [Draft] UserData as first class resource
harikrishna-patnala opened a new pull request, #6202:
URL: https://github.com/apache/cloudstack/pull/6202
### Description
This PR...
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143292255
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144448192
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1662)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144447572
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3515
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1154665726
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [32 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877524474
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/LinkUserDataToTemplateCmd.java:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "linkUserDataToTemplate", description = "Links a userdata to a template.", responseObject = TemplateResponse.class, responseView = ResponseObject.ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkUserDataToTemplateCmd extends BaseCmd implements AdminCmd {
+ public static final Logger s_logger = Logger.getLogger(LinkUserDataToTemplateCmd.class.getName());
+
+ private static final String s_name = "linkuserdatatotemplateresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.TEMPLATE_ID,
+ type = CommandType.UUID,
+ entityType = TemplateResponse.class,
+ required = true,
+ description = "the ID of the template for the virtual machine")
+ private Long templateId;
+
+ @Parameter(name = ApiConstants.USER_DATA_ID,
+ type = CommandType.UUID,
+ entityType = UserDataResponse.class,
+ required = true,
Review Comment:
we cannot remove the link of the template and the userdata, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r876923247
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/DeleteUserDataCmd.java:
##########
@@ -0,0 +1,122 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.response.DomainResponse;
+import org.apache.cloudstack.api.response.ProjectResponse;
+import org.apache.cloudstack.api.response.SuccessResponse;
+import org.apache.cloudstack.context.CallContext;
+
+
+@APICommand(name = "deleteUserData", description = "Deletes a keypair by name", responseObject = SuccessResponse.class, entityType = {UserData.class},
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false, since = "4.18")
+public class DeleteUserDataCmd extends BaseCmd {
+
+ public static final Logger s_logger = Logger.getLogger(DeleteUserDataCmd.class.getName());
+ private static final String s_name = "deleteuserdataresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.ID, type = CommandType.UUID, entityType = UserDataResponse.class, description = "the ID of the Userdata")
Review Comment:
`required=true` for `id` ?
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/LinkUserDataToTemplateCmd.java:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "linkUserDataToTemplate", description = "Links a userdata to a template.", responseObject = TemplateResponse.class, responseView = ResponseObject.ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
Review Comment:
since = "4.18" ?
##########
api/src/main/java/com/cloud/user/UserData.java:
##########
@@ -0,0 +1,30 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.user;
+
+import org.apache.cloudstack.acl.ControlledEntity;
+import org.apache.cloudstack.api.Identity;
+import org.apache.cloudstack.api.InternalIdentity;
+
+public interface UserData extends ControlledEntity, InternalIdentity, Identity {
+
+ public enum UserDataOverridePolicy { allowoverride, append, denyoverride }
Review Comment:
does this meet the java code convention ?
##########
engine/schema/src/main/java/com/cloud/vm/UserVmVO.java:
##########
@@ -42,6 +42,12 @@ public class UserVmVO extends VMInstanceVO implements UserVm {
@Basic(fetch = FetchType.LAZY)
private String userData;
+ @Column(name = "user_data_id", nullable = true, length = 17)
Review Comment:
length might be unnecessary for `user_data_id`
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4417,6 +4625,20 @@ private SSHKeyPair createAndSaveSSHKeyPair(final String name, final String finge
return newPair;
}
+ private UserData createAndSaveUserData(final String name, final String userdata, final String params, final Account owner) {
+ final UserDataVO userDataVO = new UserDataVO();
+
+ userDataVO.setAccountId(owner.getAccountId());
+ userDataVO.setDomainId(owner.getDomainId());
+ userDataVO.setName(name);
+ userDataVO.setUserData(userdata);
+ userDataVO.setParams(params);
Review Comment:
is validation on `params` required ?
e.g. format, and reserved keys
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/LinkUserDataToTemplateCmd.java:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "linkUserDataToTemplate", description = "Links a userdata to a template.", responseObject = TemplateResponse.class, responseView = ResponseObject.ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkUserDataToTemplateCmd extends BaseCmd implements AdminCmd {
+ public static final Logger s_logger = Logger.getLogger(LinkUserDataToTemplateCmd.class.getName());
+
+ private static final String s_name = "linkuserdatatotemplateresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.TEMPLATE_ID,
+ type = CommandType.UUID,
+ entityType = TemplateResponse.class,
+ required = true,
+ description = "the ID of the template for the virtual machine")
+ private Long templateId;
+
+ @Parameter(name = ApiConstants.USER_DATA_ID,
+ type = CommandType.UUID,
+ entityType = UserDataResponse.class,
+ required = true,
+ description = "the ID of the userdata that has to be linked to template")
+ private Long userdataId;
+
+ @Parameter(name = ApiConstants.USER_DATA_POLICY,
+ type = CommandType.STRING,
+ description = "an optional override policy of the userdata. Possible values are - allowoverride, append, denyoverride. Default policy is allowoverride")
+ private String userdataPolicy;
+
+ /////////////////////////////////////////////////////
+ /////////////////// Accessors ///////////////////////
+ /////////////////////////////////////////////////////
+
+ public Long getTemplateId() {
+ return templateId;
+ }
+
+ public Long getUserdataId() {
+ return userdataId;
+ }
+
+ public UserData.UserDataOverridePolicy getUserdataPolicy() {
+ if (userdataPolicy == null) {
+ return UserData.UserDataOverridePolicy.allowoverride;
+ }
+ return UserData.UserDataOverridePolicy.valueOf(userdataPolicy);
Review Comment:
userdataPolicy.toLowerCase ?
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
+ if (userDataId != null) {
+ if (userData != null) {
Review Comment:
use `StringUtils.isNotEmpty`?
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
+ if (userDataId != null) {
+ if (userData != null) {
+ s_logger.info("Both userdata and userdata ID are provided, precedence goes to userdata ID");
+ }
+ UserData apiUserDataVO = _userDataDao.findById(userDataId);
+ return apiUserDataVO.getUserData();
+ } else if (userData != null) {
+ return userData;
+ } else {
+ UserData templateUserDataVO = _userDataDao.findById(template.getUserDataId());
+ if (templateUserDataVO == null) {
+ String msg = String.format("UserData linked to the template %s is not found", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ return templateUserDataVO.getUserData();
+ }
+ case append:
Review Comment:
better to use `UserDataOverridePolicy.append"
##########
ui/src/views/compute/DeployVM.vue:
##########
@@ -562,10 +562,97 @@
@change="val => { dynamicscalingenabled = val }"/>
</a-form-item>
</a-form-item>
- <a-form-item :label="$t('label.userdata')" name="userdata" ref="userdata">
- <a-textarea
- v-model:value="form.userdata">
- </a-textarea>
+ <a-form-item :label="$t('label.userdata')">
Review Comment:
this works well.
it looks the form to update vm, register Iso, upload iso from local, update iso are not changed.
##########
api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java:
##########
@@ -227,6 +227,18 @@ public class TemplateResponse extends BaseResponseWithTagInformation implements
@Param(description = "Base64 string representation of the resource icon", since = "4.16.0.0")
ResourceIconResponse icon;
+ @SerializedName(ApiConstants.USER_DATA_ID) @Param(description="the id of userdata linked to this template", since = "4.18.0.0")
Review Comment:
it would be good to use the same value for `since`
some api/params use `4.18` and some use `4.18.0.0`
##########
engine/schema/src/main/java/com/cloud/user/UserDataVO.java:
##########
@@ -0,0 +1,117 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package com.cloud.user;
+
+import javax.persistence.Column;
+import javax.persistence.Entity;
+import javax.persistence.GeneratedValue;
+import javax.persistence.GenerationType;
+import javax.persistence.Id;
+import javax.persistence.Table;
+import java.util.UUID;
+
+@Entity
+@Table(name = "user_data")
+public class UserDataVO implements UserData {
+
+ public UserDataVO() {
+ uuid = UUID.randomUUID().toString();
+ }
+
+ @Id
+ @GeneratedValue(strategy = GenerationType.IDENTITY)
+ @Column(name = "id")
+ private Long id = null;
+
+ @Column(name = "uuid")
+ private String uuid;
+
+ @Column(name = "account_id")
+ private long accountId;
+
+ @Column(name = "domain_id")
+ private long domainId;
+
+ @Column(name = "name")
+ private String name;
+
+ @Column(name = "user_data")
Review Comment:
the default `length` for Column is 255
it would be good to set to a large value
for example, in UserVmVO.java, it has
```
@Column(name = "user_data", updatable = true, nullable = true, length = 1048576)
@Basic(fetch = FetchType.LAZY)
private String userData;
```
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -933,6 +933,331 @@ CREATE VIEW `cloud`.`event_view` AS
`cloud`.`projects` ON projects.project_account_id = event.account_id
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+-- PR#5984 Update name for global configuration vm.stats.increment.metrics
+Update configuration set name='vm.stats.increment.metrics' where name='vm.stats.increment.metrics.in.memory';
+CREATE TABLE `cloud`.`user_data` (
Review Comment:
database changes should be put in 41700to41800.sql
considering the upgrade path does not exist, we can temporarily put into 41610to41700.sql
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -933,6 +933,331 @@ CREATE VIEW `cloud`.`event_view` AS
`cloud`.`projects` ON projects.project_account_id = event.account_id
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+-- PR#5984 Update name for global configuration vm.stats.increment.metrics
Review Comment:
line 936 and 937 seem to be mistake in git merge.
##########
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java:
##########
@@ -422,6 +422,10 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
InactiveUnremovedTmpltSearch.and("removed", InactiveUnremovedTmpltSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
InactiveUnremovedTmpltSearch.done();
+ UserDataSearch = createSearchBuilder();
Review Comment:
this might not work well
when we remove a template from a zone, it will not set `removed` field in `vm_template` table.
therefore this search result will contain the templates which have been removed from the zone.
##########
api/src/main/java/org/apache/cloudstack/api/ResponseGenerator.java:
##########
@@ -22,6 +22,20 @@
import java.util.Map;
import java.util.Set;
+import com.cloud.server.ResourceIcon;
+import com.cloud.user.UserData;
+import com.cloud.utils.Pair;
+import org.apache.cloudstack.api.response.DirectDownloadCertificateResponse;
+import org.apache.cloudstack.api.response.ResourceIconResponse;
+import org.apache.cloudstack.api.response.DirectDownloadCertificateHostStatusResponse;
+import org.apache.cloudstack.api.response.RouterHealthCheckResultResponse;
+import com.cloud.resource.RollingMaintenanceManager;
+import org.apache.cloudstack.api.response.RollingMaintenanceResponse;
+import org.apache.cloudstack.direct.download.DirectDownloadCertificate;
+import org.apache.cloudstack.direct.download.DirectDownloadCertificateHostMap;
+import org.apache.cloudstack.direct.download.DirectDownloadManager;
+import org.apache.cloudstack.api.response.UserDataResponse;
Review Comment:
can these imports be ordered ?
##########
engine/schema/src/main/java/com/cloud/vm/UserVmVO.java:
##########
@@ -42,6 +42,12 @@ public class UserVmVO extends VMInstanceVO implements UserVm {
@Basic(fetch = FetchType.LAZY)
private String userData;
+ @Column(name = "user_data_id", nullable = true, length = 17)
+ private Long userDataId = null;
+
+ @Column(name = "user_data_details", updatable = true)
+ private String userDataDetails;
Review Comment:
set `length` ?
##########
server/src/main/java/com/cloud/network/element/CloudZonesNetworkElement.java:
##########
@@ -158,6 +158,19 @@ private VmDataCommand generateVmDataCommand(String vmPrivateIpAddress, String us
cmd.addVmData("metadata", "local-hostname", vmName);
cmd.addVmData("metadata", "public-ipv4", guestIpAddress);
cmd.addVmData("metadata", "public-hostname", guestIpAddress);
+
+ if(userDataDetails != null && !userDataDetails.isEmpty()) {
+ userDataDetails = userDataDetails.substring(1, userDataDetails.length()-1);
Review Comment:
@harikrishna-patnala
can you explain why `substring` is used here ?
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4336,6 +4365,174 @@ public SSHKeyPair registerSSHKeyPair(final RegisterSSHKeyPairCmd cmd) {
return createAndSaveSSHKeyPair(name, fingerprint, publicKey, null, owner);
}
+ @Override
+ public boolean deleteUserData(final DeleteUserDataCmd cmd) {
Review Comment:
would it be better to have `UserDataManager` to manage userdata actions ?
##########
server/src/main/java/com/cloud/network/router/CommandSetupHelper.java:
##########
@@ -1223,6 +1225,20 @@ private VmDataCommand generateVmDataCommand(final VirtualRouter router, final St
return cmd;
}
+ protected void addUserDataDetailsToCommand(VmDataCommand cmd, String userDataDetails) {
Review Comment:
it looks this method can also be used in `server/src/main/java/com/cloud/network/element/CloudZonesNetworkElement.java`
##########
server/src/main/java/com/cloud/network/NetworkModelImpl.java:
##########
@@ -2562,6 +2562,18 @@ public List<String[]> generateVmData(String userData, String serviceOffering, lo
vmData.add(new String[]{METATDATA_DIR, LOCAL_HOSTNAME_FILE, StringUtils.unicodeEscape(vmHostName)});
vmData.add(new String[]{METATDATA_DIR, LOCAL_IPV4_FILE, guestIpAddress});
+ if(userDataDetails != null && !userDataDetails.isEmpty()) {
+ userDataDetails = userDataDetails.substring(1, userDataDetails.length()-1);
+ String[] keyValuePairs = userDataDetails.split(",");
+ for(String pair : keyValuePairs)
+ {
+ String[] entry = pair.split("=");
+ String key = entry[0].trim();
+ String value = entry[1].trim();
+ vmData.add(new String[]{METATDATA_DIR, key, StringUtils.unicodeEscape(value)});
Review Comment:
I think some `key` are reserved, for example
SERVICE_OFFERING_FILE,
AVAILABILITY_ZONE_FILE,
LOCAL_HOSTNAME_FILE,
LOCAL_IPV4_FILE
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4336,6 +4365,174 @@ public SSHKeyPair registerSSHKeyPair(final RegisterSSHKeyPairCmd cmd) {
return createAndSaveSSHKeyPair(name, fingerprint, publicKey, null, owner);
}
+ @Override
+ public boolean deleteUserData(final DeleteUserDataCmd cmd) {
+ final Account caller = getCaller();
+ final String accountName = cmd.getAccountName();
+ final Long domainId = cmd.getDomainId();
+ final Long projectId = cmd.getProjectId();
+
+ Account owner = null;
+ try {
+ owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
+ } catch (InvalidParameterValueException ex) {
+ if (caller.getType() == Account.Type.ADMIN && accountName != null && domainId != null) {
+ owner = _accountDao.findAccountIncludingRemoved(accountName, domainId);
+ }
+ if (owner == null) {
+ throw ex;
+ }
+ }
+
+ final UserDataVO userData = _userDataDao.findById(cmd.getId());
+ if (userData == null) {
+ final InvalidParameterValueException ex = new InvalidParameterValueException(
+ "A UserData with id '" + cmd.getId() + "' does not exist for account " + owner.getAccountName() + " in specified domain id");
+ final DomainVO domain = ApiDBUtils.findDomainById(owner.getDomainId());
+ String domainUuid = String.valueOf(owner.getDomainId());
+ if (domain != null) {
+ domainUuid = domain.getUuid();
+ }
+ ex.addProxyObject(domainUuid, "domainId");
+ throw ex;
+ }
+
+ List<VMTemplateVO> templatesLinkedToUserData = _templateDao.findTemplatesLinkedToUserdata(userData.getId());
+ if (CollectionUtils.isNotEmpty(templatesLinkedToUserData)) {
+ throw new CloudRuntimeException(String.format("Userdata %s cannot be removed as it is linked to active template/templates", userData.getName()));
+ }
+
+ annotationDao.removeByEntityType(AnnotationService.EntityType.USER_DATA.name(), userData.getUuid());
+
+ return _userDataDao.expunge(userData.getId());
+ }
+
+ @Override
+ public Pair<List<? extends UserData>, Integer> listUserDatas(final ListUserDataCmd cmd) {
+ final Long id = cmd.getId();
+ final String name = cmd.getName();
+ final String keyword = cmd.getKeyword();
+
+ final Account caller = getCaller();
+ final List<Long> permittedAccounts = new ArrayList<Long>();
+
+ final Ternary<Long, Boolean, ListProjectResourcesCriteria> domainIdRecursiveListProject = new Ternary<Long, Boolean, ListProjectResourcesCriteria>(cmd.getDomainId(), cmd.isRecursive(), null);
+ _accountMgr.buildACLSearchParameters(caller, null, cmd.getAccountName(), cmd.getProjectId(), permittedAccounts, domainIdRecursiveListProject, cmd.listAll(), false);
+ final Long domainId = domainIdRecursiveListProject.first();
+ final Boolean isRecursive = domainIdRecursiveListProject.second();
+ final ListProjectResourcesCriteria listProjectResourcesCriteria = domainIdRecursiveListProject.third();
+ final SearchBuilder<UserDataVO> sb = _userDataDao.createSearchBuilder();
+ _accountMgr.buildACLSearchBuilder(sb, domainId, isRecursive, permittedAccounts, listProjectResourcesCriteria);
+ final Filter searchFilter = new Filter(UserDataVO.class, "id", false, cmd.getStartIndex(), cmd.getPageSizeVal());
+
+ final SearchCriteria<UserDataVO> sc = sb.create();
+ _accountMgr.buildACLSearchCriteria(sc, domainId, isRecursive, permittedAccounts, listProjectResourcesCriteria);
+
+ if (id != null) {
+ sc.addAnd("id", SearchCriteria.Op.EQ, id);
+ }
+
+ if (name != null) {
+ sc.addAnd("name", SearchCriteria.Op.EQ, name);
+ }
+
+ if (keyword != null) {
+ sc.addAnd("name", SearchCriteria.Op.LIKE, "%" + keyword + "%");
+ }
+
+ final Pair<List<UserDataVO>, Integer> result = _userDataDao.searchAndCount(sc, searchFilter);
+ return new Pair<List<? extends UserData>, Integer>(result.first(), result.second());
+ }
+
+ @Override
+ @ActionEvent(eventType = EventTypes.EVENT_REGISTER_USER_DATA, eventDescription = "registering userdata", async = true)
+ public UserData registerUserData(final RegisterUserDataCmd cmd) {
+ final Account owner = getOwner(cmd);
+ checkForUserDataByName(cmd, owner);
+ checkForUserData(cmd, owner);
+
+ final String name = cmd.getName();
+ String userdata = cmd.getUserData();
+ final String params = cmd.getParams();
+
+ userdata = validateUserData(userdata, cmd.getHttpMethod());
+
+ return createAndSaveUserData(name, userdata, params, owner);
+ }
+
+ private String validateUserData(String userData, BaseCmd.HTTPMethod httpmethod) {
+ byte[] decodedUserData = null;
+ if (userData != null) {
+
+ if (userData.contains("%")) {
+ try {
+ userData = URLDecoder.decode(userData, "UTF-8");
+ } catch (UnsupportedEncodingException e) {
+ throw new InvalidParameterValueException("Url decoding of userdata failed.");
+ }
+ }
+
+ if (!Base64.isBase64(userData)) {
+ throw new InvalidParameterValueException("User data is not base64 encoded");
+ }
+ // If GET, use 4K. If POST, support up to 1M.
+ if (httpmethod.equals(BaseCmd.HTTPMethod.GET)) {
+ if (userData.length() >= MAX_HTTP_GET_LENGTH) {
+ throw new InvalidParameterValueException("User data is too long for an http GET request");
+ }
+ if (userData.length() > VM_USERDATA_MAX_LENGTH.value()) {
+ throw new InvalidParameterValueException("User data has exceeded configurable max length : " + VM_USERDATA_MAX_LENGTH.value());
+ }
+ decodedUserData = Base64.decodeBase64(userData.getBytes());
+ if (decodedUserData.length > MAX_HTTP_GET_LENGTH) {
+ throw new InvalidParameterValueException("User data is too long for GET request");
+ }
+ } else if (httpmethod.equals(BaseCmd.HTTPMethod.POST)) {
+ if (userData.length() >= MAX_HTTP_POST_LENGTH) {
+ throw new InvalidParameterValueException("User data is too long for an http POST request");
+ }
+ if (userData.length() > VM_USERDATA_MAX_LENGTH.value()) {
+ throw new InvalidParameterValueException("User data has exceeded configurable max length : " + VM_USERDATA_MAX_LENGTH.value());
+ }
+ decodedUserData = Base64.decodeBase64(userData.getBytes());
+ if (decodedUserData.length > MAX_HTTP_POST_LENGTH) {
+ throw new InvalidParameterValueException("User data is too long for POST request");
+ }
+ }
+
+ if (decodedUserData == null || decodedUserData.length < 1) {
+ throw new InvalidParameterValueException("User data is too short");
+ }
+ // Re-encode so that the '=' paddings are added if necessary since 'isBase64' does not require it, but python does on the VR.
+ return Base64.encodeBase64String(decodedUserData);
+ }
+ return null;
+ }
+
+ /**
+ * @param cmd
+ * @param owner
+ * @throws InvalidParameterValueException
+ */
+ private void checkForUserData(final RegisterUserDataCmd cmd, final Account owner) throws InvalidParameterValueException {
+ final UserDataVO userData = _userDataDao.findByUserData(owner.getAccountId(), owner.getDomainId(), cmd.getUserData());
+ if (userData != null) {
+ throw new InvalidParameterValueException("A userdata with same content already exists for this account.");
Review Comment:
it would be good to add the userdata name or id in the exception.
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4336,6 +4365,174 @@ public SSHKeyPair registerSSHKeyPair(final RegisterSSHKeyPairCmd cmd) {
return createAndSaveSSHKeyPair(name, fingerprint, publicKey, null, owner);
}
+ @Override
+ public boolean deleteUserData(final DeleteUserDataCmd cmd) {
+ final Account caller = getCaller();
+ final String accountName = cmd.getAccountName();
+ final Long domainId = cmd.getDomainId();
+ final Long projectId = cmd.getProjectId();
+
+ Account owner = null;
+ try {
+ owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
+ } catch (InvalidParameterValueException ex) {
+ if (caller.getType() == Account.Type.ADMIN && accountName != null && domainId != null) {
+ owner = _accountDao.findAccountIncludingRemoved(accountName, domainId);
+ }
+ if (owner == null) {
+ throw ex;
+ }
+ }
+
+ final UserDataVO userData = _userDataDao.findById(cmd.getId());
+ if (userData == null) {
+ final InvalidParameterValueException ex = new InvalidParameterValueException(
+ "A UserData with id '" + cmd.getId() + "' does not exist for account " + owner.getAccountName() + " in specified domain id");
+ final DomainVO domain = ApiDBUtils.findDomainById(owner.getDomainId());
+ String domainUuid = String.valueOf(owner.getDomainId());
+ if (domain != null) {
+ domainUuid = domain.getUuid();
+ }
+ ex.addProxyObject(domainUuid, "domainId");
+ throw ex;
+ }
+
+ List<VMTemplateVO> templatesLinkedToUserData = _templateDao.findTemplatesLinkedToUserdata(userData.getId());
+ if (CollectionUtils.isNotEmpty(templatesLinkedToUserData)) {
+ throw new CloudRuntimeException(String.format("Userdata %s cannot be removed as it is linked to active template/templates", userData.getName()));
+ }
+
+ annotationDao.removeByEntityType(AnnotationService.EntityType.USER_DATA.name(), userData.getUuid());
+
+ return _userDataDao.expunge(userData.getId());
Review Comment:
why not use `remove` ?
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
+ if (userDataId != null) {
+ if (userData != null) {
+ s_logger.info("Both userdata and userdata ID are provided, precedence goes to userdata ID");
Review Comment:
would it be better to throw an exception if both userdata and userdataId are provided ?
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
Review Comment:
better to use `UserDataOverridePolicy.denyoverride"
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
+ if (userDataId != null) {
+ if (userData != null) {
+ s_logger.info("Both userdata and userdata ID are provided, precedence goes to userdata ID");
+ }
+ UserData apiUserDataVO = _userDataDao.findById(userDataId);
+ return apiUserDataVO.getUserData();
+ } else if (userData != null) {
+ return userData;
+ } else {
+ UserData templateUserDataVO = _userDataDao.findById(template.getUserDataId());
+ if (templateUserDataVO == null) {
+ String msg = String.format("UserData linked to the template %s is not found", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ return templateUserDataVO.getUserData();
+ }
+ case append:
+ UserData templateUserDataVO = _userDataDao.findById(template.getUserDataId());
+ if (templateUserDataVO == null) {
+ String msg = String.format("UserData linked to the template %s is not found", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ if (userDataId != null) {
+ if (userData != null) {
Review Comment:
use `StringUtils.isNotEmpty`?
##########
ui/src/config/section/compute.js:
##########
@@ -633,6 +635,77 @@ export default {
}
]
},
+ {
+ name: 'userdata',
+ title: 'label.user.data',
+ icon: 'solution-outlined',
+ docHelp: 'adminguide/virtual_machines.html#using-ssh-keys-for-authentication',
+ permission: ['listUserData'],
+ columns: () => {
+ var fields = ['name', 'id']
+ if (['Admin', 'DomainAdmin'].includes(store.getters.userInfo.roletype)) {
+ fields.push('account')
+ }
+ return fields
+ },
+ resourceType: 'UserData',
+ details: ['id', 'name', 'userdata', 'account', 'domain', 'params'],
+ related: [{
+ name: 'vm',
+ title: 'label.instances',
+ param: 'userdata'
+ }],
+ tabs: [
+ {
+ name: 'details',
+ component: shallowRef(defineAsyncComponent(() => import('@/components/view/DetailsTab.vue')))
+ },
+ {
+ name: 'comments',
Review Comment:
`Comments` tab seems not working
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
Review Comment:
better to use `UserDataOverridePolicy.allowoverride"
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
+ if (StringUtils.isNotEmpty(userData) || userDataId != null) {
+ String msg = String.format("UserData input is not allowed here since template %s is configured to deny any userdata", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ case allowoverride:
+ if (userDataId != null) {
+ if (userData != null) {
+ s_logger.info("Both userdata and userdata ID are provided, precedence goes to userdata ID");
+ }
+ UserData apiUserDataVO = _userDataDao.findById(userDataId);
+ return apiUserDataVO.getUserData();
+ } else if (userData != null) {
+ return userData;
+ } else {
+ UserData templateUserDataVO = _userDataDao.findById(template.getUserDataId());
+ if (templateUserDataVO == null) {
+ String msg = String.format("UserData linked to the template %s is not found", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ return templateUserDataVO.getUserData();
+ }
+ case append:
+ UserData templateUserDataVO = _userDataDao.findById(template.getUserDataId());
+ if (templateUserDataVO == null) {
+ String msg = String.format("UserData linked to the template %s is not found", template.getName());
+ throw new CloudRuntimeException(msg);
+ }
+ if (userDataId != null) {
+ if (userData != null) {
+ s_logger.info("Both userdata and userdata ID are provided, precedence goes to userdata ID");
Review Comment:
throw an exception ?
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/LinkUserDataToTemplateCmd.java:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "linkUserDataToTemplate", description = "Links a userdata to a template.", responseObject = TemplateResponse.class, responseView = ResponseObject.ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkUserDataToTemplateCmd extends BaseCmd implements AdminCmd {
+ public static final Logger s_logger = Logger.getLogger(LinkUserDataToTemplateCmd.class.getName());
+
+ private static final String s_name = "linkuserdatatotemplateresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.TEMPLATE_ID,
+ type = CommandType.UUID,
+ entityType = TemplateResponse.class,
+ required = true,
+ description = "the ID of the template for the virtual machine")
+ private Long templateId;
+
+ @Parameter(name = ApiConstants.USER_DATA_ID,
+ type = CommandType.UUID,
+ entityType = UserDataResponse.class,
+ required = true,
Review Comment:
we cannot remove the link the template from the userdata, right ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211817069
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211825323
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2129)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257646856
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [36 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [37.4% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.4% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1091122815
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r880174628
##########
ui/src/config/section/compute.js:
##########
@@ -633,6 +635,77 @@ export default {
}
]
},
+ {
+ name: 'userdata',
+ title: 'label.user.data',
+ icon: 'solution-outlined',
+ docHelp: 'adminguide/virtual_machines.html#using-ssh-keys-for-authentication',
+ permission: ['listUserData'],
+ columns: () => {
+ var fields = ['name', 'id']
+ if (['Admin', 'DomainAdmin'].includes(store.getters.userInfo.roletype)) {
+ fields.push('account')
+ }
+ return fields
+ },
+ resourceType: 'UserData',
+ details: ['id', 'name', 'userdata', 'account', 'domain', 'params'],
+ related: [{
+ name: 'vm',
+ title: 'label.instances',
+ param: 'userdata'
+ }],
+ tabs: [
+ {
+ name: 'details',
+ component: shallowRef(defineAsyncComponent(() => import('@/components/view/DetailsTab.vue')))
+ },
+ {
+ name: 'comments',
Review Comment:
fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1132522843
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140677110
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139518593
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139533305
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139555184
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [19.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.4% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140369587
<b>Trillian Build Failed (tid-4250)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1242699447
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1263993995
<b>Trillian test result (tid-5058)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 47443 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t5058-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 3645.81 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 560.61 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210564158
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210572870
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2124)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210771479
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254574452
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1101381345
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
||
|VirtualMachineManagerImpl|15612|0|1498|0|3072|0|
|VMTemplateVO|511|113|4|0|151|32|
|UserDataVO|54|0|0|0|22|0|
||
|UserDataDaoImpl|83|0|0|0|11|0|
|UserVmVO|136|0|2|0|43|0|
|TemplateObject|820|0|96|0|204|0|
|VMwareGuru|2768|52|222|0|512|5|
|KubernetesClusterResourceModifierActionWorker|1847|0|140|0|325|0|
|KubernetesClusterStartWorker|2686|0|168|0|426|0|
|ServiceVirtualMachine|19|0|0|0|2|0|
||
|ApiResponseHelper|11935|0|1242|0|2721|0|
|TemplateJoinDaoImpl|1506|0|140|0|304|0|
|TemplateJoinVO|243|0|0|0|83|0|
|NetworkModelImpl|5791|0|792|0|1240|0|
|AutoScaleManagerImpl|3303|0|320|0|691|0|
|CloudZonesNetworkElement|387|0|28|0|89|0|
|ConfigDriveNetworkElement|1470|0|173|0|306|0|
|CommandSetupHelper|3750|0|270|0|699|0|
|ManagementServerImpl|12261|0|1096|0|2456|0|
|TemplateManagerImpl|5073|0|700|0|1056|0|
|UserVmManagerImpl|21079|0|2616|0|3926|0|
||
||
||
||
||
||
||
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1101347944
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1132526901
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1602)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r879969610
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4336,6 +4365,174 @@ public SSHKeyPair registerSSHKeyPair(final RegisterSSHKeyPairCmd cmd) {
return createAndSaveSSHKeyPair(name, fingerprint, publicKey, null, owner);
}
+ @Override
+ public boolean deleteUserData(final DeleteUserDataCmd cmd) {
Review Comment:
Thats a good suggestion but I think going forward it is better to keep one separate manager for all userdata services in network offering like passwords, userdata, metada. So I'm keeping this here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140369432
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141059458
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140692363
<b>Trillian test result (tid-4251)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 345 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4251-xenserver-71.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140858360
<b>Trillian test result (tid-4257)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 358 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4257-kvm-centos7.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140678394
<b>Trillian Build Failed (tid-4252)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r884838462
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -934,6 +934,330 @@ CREATE VIEW `cloud`.`event_view` AS
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+CREATE TABLE `cloud`.`user_data` (
+ `id` bigint unsigned NOT NULL auto_increment COMMENT 'id',
+ `uuid` varchar(40) NOT NULL COMMENT 'UUID of the user data',
+ `name` varchar(256) NOT NULL COMMENT 'name of the user data',
+ `account_id` bigint unsigned NOT NULL COMMENT 'owner, foreign key to account table',
+ `domain_id` bigint unsigned NOT NULL COMMENT 'domain, foreign key to domain table',
+ `user_data` mediumtext COMMENT 'value of the userdata',
+ `params` mediumtext COMMENT 'value of the comma-separated list of parameters',
+ PRIMARY KEY (`id`),
+ CONSTRAINT `fk_userdata__account_id` FOREIGN KEY(`account_id`) REFERENCES `account` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `fk_userdata__domain_id` FOREIGN KEY(`domain_id`) REFERENCES `domain` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `uc_userdata__uuid` UNIQUE (`uuid`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data' AFTER `user_data`;
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_details` mediumtext DEFAULT NULL COMMENT 'value of the comma-separated list of parameters' AFTER `user_data_id`;
+ALTER TABLE `cloud`.`user_vm` ADD CONSTRAINT `fk_user_vm__user_data_id` FOREIGN KEY `fk_user_vm__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
+
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data';
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_link_policy` varchar(255) DEFAULT NULL COMMENT 'user data link policy with template';
+ALTER TABLE `cloud`.`vm_template` ADD CONSTRAINT `fk_vm_template__user_data_id` FOREIGN KEY `fk_vm_template__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
Review Comment:
@harikrishna-patnala
there is `user_data`(`id`) ON DELETE CASCADE` in line 953 and line 957, which leads to the issue that the user_vm and vm_template records will be removed from database when a userdata is removed.
please consider
(1) remove the `ON DELETE CASCADE`, OR
(2) add `removed` to `user_data` table so the record will not be removed from database, OR
(3) do not allow deletion of `user_data` if it is used by a user vm. (I think the check on vm_template already exists)
3 is not good in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1133032358
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144007323
<b>Trillian test result (tid-4272)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 35133 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4272-kvm-centos7.zip
Smoke tests completed. 92 look OK, 6 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_link_and_unlink_userdata_to_template | `Failure` | 3.88 | test_register_userdata.py
test_01_events_resource | `Error` | 1.77 | test_events_resource.py
test_01_events_resource | `Error` | 1.77 | test_events_resource.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 1.29 | test_persistent_network.py
test_01_verify_ipv6_network | `Error` | 1.52 | test_network_ipv6.py
test_02_verify_ipv6_network_redundant | `Error` | 317.34 | test_network_ipv6.py
test_01_nic | `Error` | 65.28 | test_nic.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.38 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.40 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 17.35 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 17.38 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 31.24 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1142421716
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1122010081
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [0.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [9.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1121975479
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1539)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129626267
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1114688615
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1154636142
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129628692
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r879969835
##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -5597,6 +5616,79 @@ public HypervisorType getHypervisorTypeOfUserVM(long vmId) {
return userVm.getHypervisorType();
}
+ protected String finalizeUserData(String userData, Long userDataId, VirtualMachineTemplate template) {
+ if (StringUtils.isEmpty(userData) && userDataId == null && (template == null || template.getUserDataId() == null)) {
+ return null;
+ }
+ if (template != null && template.getUserDataId() != null) {
+ switch (template.getUserDataOverridePolicy()) {
+ case denyoverride:
Review Comment:
This is enum inside an interface, so cannot use that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129636365
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877782702
##########
server/src/main/java/com/cloud/server/ManagementServerImpl.java:
##########
@@ -4336,6 +4365,174 @@ public SSHKeyPair registerSSHKeyPair(final RegisterSSHKeyPairCmd cmd) {
return createAndSaveSSHKeyPair(name, fingerprint, publicKey, null, owner);
}
+ @Override
+ public boolean deleteUserData(final DeleteUserDataCmd cmd) {
+ final Account caller = getCaller();
+ final String accountName = cmd.getAccountName();
+ final Long domainId = cmd.getDomainId();
+ final Long projectId = cmd.getProjectId();
+
+ Account owner = null;
+ try {
+ owner = _accountMgr.finalizeOwner(caller, accountName, domainId, projectId);
+ } catch (InvalidParameterValueException ex) {
+ if (caller.getType() == Account.Type.ADMIN && accountName != null && domainId != null) {
+ owner = _accountDao.findAccountIncludingRemoved(accountName, domainId);
+ }
+ if (owner == null) {
+ throw ex;
+ }
+ }
+
+ final UserDataVO userData = _userDataDao.findById(cmd.getId());
+ if (userData == null) {
+ final InvalidParameterValueException ex = new InvalidParameterValueException(
+ "A UserData with id '" + cmd.getId() + "' does not exist for account " + owner.getAccountName() + " in specified domain id");
+ final DomainVO domain = ApiDBUtils.findDomainById(owner.getDomainId());
+ String domainUuid = String.valueOf(owner.getDomainId());
+ if (domain != null) {
+ domainUuid = domain.getUuid();
+ }
+ ex.addProxyObject(domainUuid, "domainId");
+ throw ex;
+ }
+
+ List<VMTemplateVO> templatesLinkedToUserData = _templateDao.findTemplatesLinkedToUserdata(userData.getId());
+ if (CollectionUtils.isNotEmpty(templatesLinkedToUserData)) {
+ throw new CloudRuntimeException(String.format("Userdata %s cannot be removed as it is linked to active template/templates", userData.getName()));
+ }
+
+ annotationDao.removeByEntityType(AnnotationService.EntityType.USER_DATA.name(), userData.getUuid());
+
+ return _userDataDao.expunge(userData.getId());
Review Comment:
Userdata vo does not have a removed column, so we are directly expunging it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877779613
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -933,6 +933,331 @@ CREATE VIEW `cloud`.`event_view` AS
`cloud`.`projects` ON projects.project_account_id = event.account_id
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+-- PR#5984 Update name for global configuration vm.stats.increment.metrics
+Update configuration set name='vm.stats.increment.metrics' where name='vm.stats.increment.metrics.in.memory';
+CREATE TABLE `cloud`.`user_data` (
Review Comment:
This is temporary, will move to 41700to41800.sql once available
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144443458
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1138428625
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1625)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144396871
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [19.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210621266
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210876048
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211818194
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211865988
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257695519
Packaging result: :heavy_multiplication_x: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257553542
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r979808810
##########
ui/src/config/section/image.js:
##########
@@ -195,7 +195,7 @@ export default {
}
return fields
},
- details: ['name', 'id', 'displaytext', 'checksum', 'ostypename', 'size', 'bootable', 'isready', 'directdownload', 'isextractable', 'ispublic', 'isfeatured', 'crosszones', 'account', 'domain', 'created'],
+ details: ['name', 'id', 'displaytext', 'checksum', 'ostypename', 'size', 'bootable', 'isready', 'directdownload', 'isextractable', 'ispublic', 'isfeatured', 'crosszones', 'account', 'domain', 'created', 'userdatadetails', 'userdatapolicy'],
Review Comment:
same as above ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1263180565
@vladimirpetrov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257617772
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257839602
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1259435359
@harikrishna-patnala can you look at the conflicts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1101352895
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1392)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1088249165
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210879316
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.0% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211815968
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1263180324
@blueorangutan test centos7 kvm-centos7 keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257790433
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257987676
@vladimirpetrov a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129611401
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129621259
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1584)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129629385
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129688508
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [86 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1096455131
> Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?
@harikrishna-patnala ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1095094202
Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1138424739
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141064926
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1636)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r885153156
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -934,6 +934,330 @@ CREATE VIEW `cloud`.`event_view` AS
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+CREATE TABLE `cloud`.`user_data` (
+ `id` bigint unsigned NOT NULL auto_increment COMMENT 'id',
+ `uuid` varchar(40) NOT NULL COMMENT 'UUID of the user data',
+ `name` varchar(256) NOT NULL COMMENT 'name of the user data',
+ `account_id` bigint unsigned NOT NULL COMMENT 'owner, foreign key to account table',
+ `domain_id` bigint unsigned NOT NULL COMMENT 'domain, foreign key to domain table',
+ `user_data` mediumtext COMMENT 'value of the userdata',
+ `params` mediumtext COMMENT 'value of the comma-separated list of parameters',
+ PRIMARY KEY (`id`),
+ CONSTRAINT `fk_userdata__account_id` FOREIGN KEY(`account_id`) REFERENCES `account` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `fk_userdata__domain_id` FOREIGN KEY(`domain_id`) REFERENCES `domain` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `uc_userdata__uuid` UNIQUE (`uuid`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data' AFTER `user_data`;
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_details` mediumtext DEFAULT NULL COMMENT 'value of the comma-separated list of parameters' AFTER `user_data_id`;
+ALTER TABLE `cloud`.`user_vm` ADD CONSTRAINT `fk_user_vm__user_data_id` FOREIGN KEY `fk_user_vm__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
+
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data';
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_link_policy` varchar(255) DEFAULT NULL COMMENT 'user data link policy with template';
+ALTER TABLE `cloud`.`vm_template` ADD CONSTRAINT `fk_vm_template__user_data_id` FOREIGN KEY `fk_vm_template__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
Review Comment:
Good catch @weizhouapache thanks. But for some reason I did not observe this happening on deletion of userdata, may be because of other foreign key constraints. But yeah better to remove this. I've updated the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140720295
<b>Trillian Build Failed (tid-4254)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r884838462
##########
engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql:
##########
@@ -934,6 +934,330 @@ CREATE VIEW `cloud`.`event_view` AS
LEFT JOIN
`cloud`.`event` eve ON event.start_id = eve.id;
+CREATE TABLE `cloud`.`user_data` (
+ `id` bigint unsigned NOT NULL auto_increment COMMENT 'id',
+ `uuid` varchar(40) NOT NULL COMMENT 'UUID of the user data',
+ `name` varchar(256) NOT NULL COMMENT 'name of the user data',
+ `account_id` bigint unsigned NOT NULL COMMENT 'owner, foreign key to account table',
+ `domain_id` bigint unsigned NOT NULL COMMENT 'domain, foreign key to domain table',
+ `user_data` mediumtext COMMENT 'value of the userdata',
+ `params` mediumtext COMMENT 'value of the comma-separated list of parameters',
+ PRIMARY KEY (`id`),
+ CONSTRAINT `fk_userdata__account_id` FOREIGN KEY(`account_id`) REFERENCES `account` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `fk_userdata__domain_id` FOREIGN KEY(`domain_id`) REFERENCES `domain` (`id`) ON DELETE CASCADE,
+ CONSTRAINT `uc_userdata__uuid` UNIQUE (`uuid`)
+) ENGINE=InnoDB DEFAULT CHARSET=utf8;
+
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data' AFTER `user_data`;
+ALTER TABLE `cloud`.`user_vm` ADD COLUMN `user_data_details` mediumtext DEFAULT NULL COMMENT 'value of the comma-separated list of parameters' AFTER `user_data_id`;
+ALTER TABLE `cloud`.`user_vm` ADD CONSTRAINT `fk_user_vm__user_data_id` FOREIGN KEY `fk_user_vm__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
+
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_id` bigint unsigned DEFAULT NULL COMMENT 'id of the user data';
+ALTER TABLE `cloud`.`vm_template` ADD COLUMN `user_data_link_policy` varchar(255) DEFAULT NULL COMMENT 'user data link policy with template';
+ALTER TABLE `cloud`.`vm_template` ADD CONSTRAINT `fk_vm_template__user_data_id` FOREIGN KEY `fk_vm_template__user_data_id`(`user_data_id`) REFERENCES `user_data`(`id`) ON DELETE CASCADE;
Review Comment:
@harikrishna-patnala
there is `user_data`(`id`) ON DELETE CASCADE` in line 953 and line 957, which leads to the issue that the user_vm and vm_template records will be removed from database when a userdata is removed.
please consider
(1) remove the `ON DELETE CASCADE`, OR
(2) add `removed` to `user_data` table so the record will not be removed from database, OR
(3) do not allow deleltion of `user_data` if it is used by a user vm. (I think the check on vm_template already exists)
3 is not good in my opinion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141624693
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [20.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144476950
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143161630
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145623432
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145627711
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1669)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1135585064
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [26 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [4.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139571782
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1138424088
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1134685632
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1134685197
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877802479
##########
api/src/main/java/org/apache/cloudstack/api/response/UserDataResponse.java:
##########
@@ -0,0 +1,136 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.api.response;
+
+import com.cloud.serializer.Param;
+import com.cloud.user.UserData;
+import com.google.gson.annotations.SerializedName;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.BaseResponseWithAnnotations;
+import org.apache.cloudstack.api.EntityReference;
+
+@EntityReference(value = UserData.class)
+public class UserDataResponse extends BaseResponseWithAnnotations {
+
+ @SerializedName(ApiConstants.ID)
+ @Param(description = "ID of the ssh keypair")
+ private String id;
+
+ @SerializedName(ApiConstants.NAME)
+ @Param(description = "Name of the userdata")
+ private String name;
+
+ @SerializedName(ApiConstants.ACCOUNT_ID) @Param(description="the owner id of the userdata")
+ private String accountId;
+
+ @SerializedName(ApiConstants.ACCOUNT) @Param(description="the owner of the userdata")
+ private String accountName;
+
+ @SerializedName(ApiConstants.DOMAIN_ID) @Param(description="the domain id of the userdata owner")
+ private String domainId;
+
+ @SerializedName(ApiConstants.DOMAIN) @Param(description="the domain name of the userdata owner")
+ private String domain;
+
+ @SerializedName(ApiConstants.USER_DATA) @Param(description="the userdata content")
Review Comment:
@harikrishna-patnala
it would be good to mention that the userdata is base64-encoded.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1132523369
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141102462
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143165945
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1649)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140366827
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140369583
<b>Trillian Build Failed (tid-4248)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144482796
<b>Trillian test result (tid-4277)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38647 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4277-kvm-centos7.zip
Smoke tests completed. 92 look OK, 6 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_link_and_unlink_userdata_to_template | `Failure` | 3.91 | test_register_userdata.py
test_01_events_resource | `Error` | 2.06 | test_events_resource.py
test_01_events_resource | `Error` | 2.07 | test_events_resource.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 1.29 | test_persistent_network.py
test_01_verify_ipv6_network | `Error` | 1.54 | test_network_ipv6.py
test_02_verify_ipv6_network_redundant | `Error` | 313.03 | test_network_ipv6.py
test_01_nic | `Error` | 65.64 | test_nic.py
test_hostha_enable_ha_when_host_disabled | `Error` | 2.73 | test_hostha_kvm.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 301.74 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145626338
<b>Trillian Build Failed (tid-4284)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145677048
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1670)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145671512
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144356170
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210782479
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2126)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210604934
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3959
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1091123567
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] ravening commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
ravening commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1095141522
> Hi @ravening, your pull request has merge conflicts. Can you fix the conflicts and sync your branch with the base branch?
you are drunk. get some sleep :P
this is not my pr :D
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1121972360
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254634429
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [38 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [36.9% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257789388
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1091150917
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3092
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1134748588
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [26 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [4.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140146591
<b>Trillian test result (tid-4247)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 369 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4247-vmware-65u2.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141601547
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141060980
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140856734
<b>Trillian test result (tid-4256)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4256-xenserver-71.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141114697
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1637)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144036488
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145623990
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144477552
@harikrishna-patnala a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1106813996
@harikrishna-patnala could you add some description to the PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1121971619
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1122029895
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129556726
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129635086
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1587)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1131542688
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1114731021
## PR Analysis
https://sonarcloud.io/summary/new_code?id=apachecloudstack&pullRequest=6202
## PR Coverage Report
|**CLASS**|**INSTRUCTION MISSED**|**INSTRUCTION COVERED**|**BRANCH MISSED**|**BRANCH COVERED**|**LINE MISSED**|**LINE COVERED**|
|-----|-----|-----|-----|-----|-----|-----|
|VirtualMachineManagerImpl|15661|0|1500|0|3079|0|
|VMTemplateVO|511|113|4|0|151|32|
|VMTemplateDaoImpl|2406|0|82|0|379|0|
|UserDataVO|54|0|0|0|22|0|
|UserDataDaoImpl|83|0|0|0|11|0|
|UserVmVO|136|0|2|0|43|0|
|UserVmDaoImpl|1948|0|82|0|361|0|
|TemplateObject|820|0|96|0|204|0|
|VMwareGuru|2768|52|222|0|512|5|
|KubernetesClusterResourceModifierActionWorker|1847|0|140|0|325|0|
|KubernetesClusterStartWorker|2686|0|168|0|426|0|
|ServiceVirtualMachine|19|0|0|0|2|0|
|ApiResponseHelper|12458|0|1292|0|2847|0|
|TemplateJoinDaoImpl|1539|0|142|0|313|0|
|UserVmJoinDaoImpl|1550|0|186|0|333|0|
|TemplateJoinVO|246|0|0|0|84|0|
|UserVmJoinVO|427|0|4|0|136|0|
|NetworkModelImpl|6247|0|844|0|1308|0|
|AutoScaleManagerImpl|3303|0|320|0|691|0|
|CloudZonesNetworkElement|387|0|28|0|89|0|
|ConfigDriveNetworkElement|1470|0|173|0|306|0|
|CommandSetupHelper|4140|0|306|0|777|0|
|ManagementServerImpl|12716|0|1126|0|2538|0|
|TemplateManagerImpl|5088|0|700|0|1059|0|
|UserVmManager|33|0|0|0|3|0|
|UserVmManagerImpl|21090|0|2616|0|3931|0|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1154639652
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1725)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210776657
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210775388
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1259074112
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on a diff in pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r884922901
##########
ui/src/config/section/image.js:
##########
@@ -47,7 +47,7 @@ export default {
details: () => {
var fields = ['name', 'id', 'displaytext', 'checksum', 'hypervisor', 'format', 'ostypename', 'size', 'isready', 'passwordenabled',
'directdownload', 'deployasis', 'ispublic', 'isfeatured', 'isextractable', 'isdynamicallyscalable', 'crosszones', 'type',
- 'account', 'domain', 'created']
+ 'account', 'domain', 'created', 'userdatadetails', 'userdatapolicy']
Review Comment:
@harikrishna-patnala
`userdata` is displayed in the info card, would it be good to add `userdata` as well ?
##########
ui/src/config/section/image.js:
##########
@@ -195,7 +195,7 @@ export default {
}
return fields
},
- details: ['name', 'id', 'displaytext', 'checksum', 'ostypename', 'size', 'bootable', 'isready', 'directdownload', 'isextractable', 'ispublic', 'isfeatured', 'crosszones', 'account', 'domain', 'created'],
+ details: ['name', 'id', 'displaytext', 'checksum', 'ostypename', 'size', 'bootable', 'isready', 'directdownload', 'isextractable', 'ispublic', 'isfeatured', 'crosszones', 'account', 'domain', 'created', 'userdatadetails', 'userdatapolicy'],
Review Comment:
@harikrishna-patnala
userdata is displayed in the info card, would it be good to add userdata as well ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r979808357
##########
ui/src/config/section/image.js:
##########
@@ -47,7 +47,7 @@ export default {
details: () => {
var fields = ['name', 'id', 'displaytext', 'checksum', 'hypervisor', 'format', 'ostypename', 'size', 'isready', 'passwordenabled',
'directdownload', 'deployasis', 'ispublic', 'isfeatured', 'isextractable', 'isdynamicallyscalable', 'crosszones', 'type',
- 'account', 'domain', 'created']
+ 'account', 'domain', 'created', 'userdatadetails', 'userdatapolicy']
Review Comment:
we already have userdata in the left section and is routable. Other information like details and policy are kept in the details section.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210851879
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3960
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210560662
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1116615337
(@harikrishna-patnala I'm testing new sonarcloud/bot integration, merging your PR branch with main to see how coverage analysis behaves)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1122066817
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3377
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129612177
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1101347785
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257559552
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2420)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254604466
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4243
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254573530
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257987301
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265384301
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 4342
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] vladimirpetrov commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
vladimirpetrov commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265320114
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140146871
<b>Trillian test result (tid-4245)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 370 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4245-xenserver-71.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140828440
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140854236
<b>Trillian test result (tid-4258)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 356 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4258-vmware-65u2.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140137216
@blueorangutan test matrix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140147088
<b>Trillian test result (tid-4246)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 355 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4246-kvm-centos7.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala closed pull request #6202: [Draft] UserData as first class resource
URL: https://github.com/apache/cloudstack/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143293049
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145108979
<b>Trillian test result (tid-4278)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38499 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4278-kvm-centos7.zip
Smoke tests completed. 97 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestSharedNetwork>:setup | `Error` | 44.40 | test_network.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145664560
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [32 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145672476
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala closed pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala closed pull request #6202: [Draft] UserData as first class resource
URL: https://github.com/apache/cloudstack/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144405856
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1131542030
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1133040524
> SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
>
> [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [87 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
>
> [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.6% Dup
lication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
87 code smells according to sonarcloud. Can you glance at those please @harikrishna-patnala ? some of those might make sense to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877784870
##########
ui/src/views/compute/DeployVM.vue:
##########
@@ -562,10 +562,97 @@
@change="val => { dynamicscalingenabled = val }"/>
</a-form-item>
</a-form-item>
- <a-form-item :label="$t('label.userdata')" name="userdata" ref="userdata">
- <a-textarea
- v-model:value="form.userdata">
- </a-textarea>
+ <a-form-item :label="$t('label.userdata')">
Review Comment:
again, updateVM changes are lost during rebase. I'll add them again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1120144591
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1122030425
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129557163
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129583125
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [84 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129674890
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [86 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1088264915
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145623160
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139575924
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1629)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140137319
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141060379
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141123248
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [20.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143252116
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3512
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144359765
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1660)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144442914
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1134691147
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1615)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877781801
##########
server/src/main/java/com/cloud/network/element/CloudZonesNetworkElement.java:
##########
@@ -158,6 +158,19 @@ private VmDataCommand generateVmDataCommand(String vmPrivateIpAddress, String us
cmd.addVmData("metadata", "local-hostname", vmName);
cmd.addVmData("metadata", "public-ipv4", guestIpAddress);
cmd.addVmData("metadata", "public-hostname", guestIpAddress);
+
+ if(userDataDetails != null && !userDataDetails.isEmpty()) {
+ userDataDetails = userDataDetails.substring(1, userDataDetails.length()-1);
Review Comment:
userdatadetails is saved a map (eg. {key1=test1, key2=test2}) so are removing those braces here. Do you think it has to be removed while saving itself ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877782166
##########
engine/schema/src/main/java/com/cloud/storage/dao/VMTemplateDaoImpl.java:
##########
@@ -422,6 +422,10 @@ public boolean configure(String name, Map<String, Object> params) throws Configu
InactiveUnremovedTmpltSearch.and("removed", InactiveUnremovedTmpltSearch.entity().getRemoved(), SearchCriteria.Op.NULL);
InactiveUnremovedTmpltSearch.done();
+ UserDataSearch = createSearchBuilder();
Review Comment:
updated the query with state "Active"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1131590951
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [87 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [5.9% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1131547435
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1597)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139572193
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139614178
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [20.5% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.3% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210561175
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1253368237
@harikrishna-patnala you have a conflict
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1258927166
<b>Trillian test result (tid-5017)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 52385 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t5017-vmware-65u2.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_deploy_vm_on_specific_host | `Error` | 20.89 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 3604.86 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 3.34 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 3.41 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 2.31 | test_vm_deployment_planner.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1268941949
<b>Trillian test result (tid-5069)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 39314 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t5069-kvm-centos7.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265119895
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265043918
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254579914
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2398)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254574926
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265321185
@vladimirpetrov a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129635587
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1154636633
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1088247962
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1088276123
<b>Trillian Build Failed (tid-3816)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210778158
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-2125)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210774949
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210775964
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210563276
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1210770120
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1157472568
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139518117
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140369584
<b>Trillian Build Failed (tid-4249)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139533167
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139560467
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3490
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1135532680
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1135537066
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1618)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141060131
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141104730
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141108122
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: debian. SL-JID 3498
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141134632
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3500
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141100341
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with
SystemVM template(s). I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143196806
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140677476
@harikrishna-patnala a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143197383
@weizhouapache a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145623585
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1145723471
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [32 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [23.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144356420
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144405772
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1104698147
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1265122551
@harikrishna-patnala a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1132563195
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [87 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [15.7% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [6.6% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1105751046
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1121941664
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [8 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [54 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [0.1% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [9.0% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud closed pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
rohityadavcloud closed pull request #6202: [Draft] UserData as first class resource
URL: https://github.com/apache/cloudstack/pull/6202
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129625701
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129559627
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1583)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1129643728
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1588)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211818864
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1211851387
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 3963
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257552760
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] github-actions[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1255082102
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1257614921
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254749173
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6202?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6202](https://codecov.io/gh/apache/cloudstack/pull/6202?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0b4c9d9) into [main](https://codecov.io/gh/apache/cloudstack/commit/434f15a9b29d788ca9ba7108ebfd81763ab3f356?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (434f15a) will **increase** coverage by `0.06%`.
> The diff coverage is `44.68%`.
```diff
@@ Coverage Diff @@
## main #6202 +/- ##
============================================
+ Coverage 10.42% 10.48% +0.06%
- Complexity 6701 6763 +62
============================================
Files 2458 2460 +2
Lines 243246 243638 +392
Branches 38067 38125 +58
============================================
+ Hits 25358 25554 +196
- Misses 214713 214877 +164
- Partials 3175 3207 +32
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6202?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...n/java/com/cloud/vm/VirtualMachineManagerImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL29yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9jb20vY2xvdWQvdm0vVmlydHVhbE1hY2hpbmVNYW5hZ2VySW1wbC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../src/main/java/com/cloud/storage/VMTemplateVO.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL1ZNVGVtcGxhdGVWTy5qYXZh) | `36.61% <0.00%> (-1.25%)` | :arrow_down: |
| [.../java/com/cloud/storage/dao/VMTemplateDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC9zdG9yYWdlL2Rhby9WTVRlbXBsYXRlRGFvSW1wbC5qYXZh) | `1.82% <0.00%> (-0.04%)` | :arrow_down: |
| [.../main/java/com/cloud/user/dao/UserDataDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC91c2VyL2Rhby9Vc2VyRGF0YURhb0ltcGwuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../src/main/java/com/cloud/vm/dao/UserVmDaoImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3NjaGVtYS9zcmMvbWFpbi9qYXZhL2NvbS9jbG91ZC92bS9kYW8vVXNlclZtRGFvSW1wbC5qYXZh) | `0.81% <0.00%> (-0.02%)` | :arrow_down: |
| [...dstack/storage/configdrive/ConfigDriveBuilder.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2UvY29uZmlnZHJpdmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9jb25maWdkcml2ZS9Db25maWdEcml2ZUJ1aWxkZXIuamF2YQ==) | `10.27% <0.00%> (-0.76%)` | :arrow_down: |
| [...cloudstack/storage/image/store/TemplateObject.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL3N0b3JhZ2UvaW1hZ2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svc3RvcmFnZS9pbWFnZS9zdG9yZS9UZW1wbGF0ZU9iamVjdC5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ain/java/com/cloud/hypervisor/guru/VMwareGuru.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy92bXdhcmUvc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9ndXJ1L1ZNd2FyZUd1cnUuamF2YQ==) | `0.93% <ø> (ø)` | |
| [...KubernetesClusterResourceModifierActionWorker.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9hY3Rpb253b3JrZXJzL0t1YmVybmV0ZXNDbHVzdGVyUmVzb3VyY2VNb2RpZmllckFjdGlvbldvcmtlci5qYXZh) | `0.00% <ø> (ø)` | |
| [...er/actionworkers/KubernetesClusterStartWorker.java](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9pbnRlZ3JhdGlvbnMva3ViZXJuZXRlcy1zZXJ2aWNlL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL2t1YmVybmV0ZXMvY2x1c3Rlci9hY3Rpb253b3JrZXJzL0t1YmVybmV0ZXNDbHVzdGVyU3RhcnRXb3JrZXIuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [24 more](https://codecov.io/gh/apache/cloudstack/pull/6202/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1258784357
<b>Trillian test result (tid-5015)</b>
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 38470 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t5015-xenserver-71.zip
Smoke tests completed. 104 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1258829444
<b>Trillian test result (tid-5016)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41754 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t5016-kvm-centos7.zip
Smoke tests completed. 103 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_upgrade_kubernetes_cluster | `Failure` | 488.03 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 544.31 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1254572875
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1135531712
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877784277
##########
api/src/main/java/org/apache/cloudstack/api/command/user/userdata/LinkUserDataToTemplateCmd.java:
##########
@@ -0,0 +1,118 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package org.apache.cloudstack.api.command.user.userdata;
+
+import com.cloud.template.VirtualMachineTemplate;
+import com.cloud.user.Account;
+import com.cloud.user.UserData;
+import com.cloud.utils.exception.CloudRuntimeException;
+import org.apache.cloudstack.api.APICommand;
+import org.apache.cloudstack.api.ApiConstants;
+import org.apache.cloudstack.api.ApiErrorCode;
+import org.apache.cloudstack.api.BaseCmd;
+import org.apache.cloudstack.api.Parameter;
+import org.apache.cloudstack.api.ResponseObject;
+import org.apache.cloudstack.api.ServerApiException;
+import org.apache.cloudstack.api.command.admin.AdminCmd;
+import org.apache.cloudstack.api.response.TemplateResponse;
+import org.apache.cloudstack.api.response.UserDataResponse;
+import org.apache.log4j.Logger;
+
+@APICommand(name = "linkUserDataToTemplate", description = "Links a userdata to a template.", responseObject = TemplateResponse.class, responseView = ResponseObject.ResponseView.Restricted,
+ requestHasSensitiveInfo = false, responseHasSensitiveInfo = false)
+public class LinkUserDataToTemplateCmd extends BaseCmd implements AdminCmd {
+ public static final Logger s_logger = Logger.getLogger(LinkUserDataToTemplateCmd.class.getName());
+
+ private static final String s_name = "linkuserdatatotemplateresponse";
+
+ /////////////////////////////////////////////////////
+ //////////////// API parameters /////////////////////
+ /////////////////////////////////////////////////////
+
+ @Parameter(name = ApiConstants.TEMPLATE_ID,
+ type = CommandType.UUID,
+ entityType = TemplateResponse.class,
+ required = true,
+ description = "the ID of the template for the virtual machine")
+ private Long templateId;
+
+ @Parameter(name = ApiConstants.USER_DATA_ID,
+ type = CommandType.UUID,
+ entityType = UserDataResponse.class,
+ required = true,
Review Comment:
We can remove the link, when userdata is not provided it will unlink the existing one. Looks like some issue happened with rebase, I've now removed the required param here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] harikrishna-patnala commented on a diff in pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
harikrishna-patnala commented on code in PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#discussion_r877778718
##########
api/src/main/java/org/apache/cloudstack/api/response/TemplateResponse.java:
##########
@@ -227,6 +227,18 @@ public class TemplateResponse extends BaseResponseWithTagInformation implements
@Param(description = "Base64 string representation of the resource icon", since = "4.16.0.0")
ResourceIconResponse icon;
+ @SerializedName(ApiConstants.USER_DATA_ID) @Param(description="the id of userdata linked to this template", since = "4.18.0.0")
Review Comment:
used 4.18.0 in all places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] weizhouapache commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
weizhouapache commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1141100023
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140828781
@weizhouapache a Trillian-Jenkins matrix job (centos7 mgmt + xs71, centos7 mgmt + vmware65, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1140691511
<b>Trillian test result (tid-4253)</b>
Environment: vmware-65u2 (x2), Advanced Networking with Mgmt server 7
Total time taken: 363 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr6202-t4253-vmware-65u2.zip
Smoke tests completed. 0 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1138510068
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [33 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [19.6% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.5% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1139521929
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6202 (SL-JID-1628)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143199363
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [19.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144037181
@weizhouapache a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
rohityadavcloud commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143481066
Great to see double-digit coverage, can we see how this can improve further @harikrishna-patnala ? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1143161368
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #6202: [Draft] UserData as first class resource
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #6202:
URL: https://github.com/apache/cloudstack/pull/6202#issuecomment-1144469582
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=6202)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=6202&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL) [34 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=6202&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list) [19.3% Coverage](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list) [7.1% Duplication](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=6202&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org