[jira] [Commented] (TEZ-1724) Refactoring - Consolidate ROOT_INPUT and INPUT

["Siddharth Seth (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-1724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191465#comment-14191465 ] 

Siddharth Seth commented on TEZ-1724:
-------------------------------------

Changes sound good. 
Maybe VertexEventRootInputFailed -> VertexEventInputInitFailed instead of VertexEventInputFailed since this is the initializer which is failing. I think your patch on TEZ-1703 had this.

It'd be better to make these changes after TEZ-1547 goes in though - since it'll likely cause conflicts otherwise.

> Refactoring - Consolidate ROOT_INPUT and INPUT
> ----------------------------------------------
>
>                 Key: TEZ-1724
>                 URL: https://issues.apache.org/jira/browse/TEZ-1724
>             Project: Apache Tez
>          Issue Type: Bug
>    Affects Versions: 0.5.1
>            Reporter: Jeff Zhang
>
> Some places we use ROOT_INPUT , while other places we use INPUT (Actually Input can been attached to one non-root-vertex, so I think we need to consolidate them both to INPUT). Here're some places need to refractor.
> * RootInputInitializerManager -> InputInitializerManager
> * TezRootInputInitializerContextImpl -> TezInputInitializerContextImpl
> * VertexEventRootInputInitialized -> VertexEventInputInitialized
> * VertexEventRootInputFailed -> VertexEventInputFailed
> * VertexTerminationCause.ROOT_INPUT_INIT_FAILURE -> VertexTerminationCause.INPUT_INIT_FAILURE.
> * EventType.ROOT_INPUT_DATA_INFORMATION_EVENT -> EventType.INPUT_DATA_INFORMATION_EVENT
> * EventType.ROOT_INPUT_INITIALIZER_EVENT -> EventType.INPUT_INITIALIZER_EVENT
> * VertexEventType.V_ROOT_INPUT_INITIALIZED -> VertexEventType.V_INPUT_INITIALIZED
> * VertexEventType.V_ROOT_INPUT_FAILED -> VertexEventType.V_INPUT_INIT_FAILED



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)