[GitHub] [ozone] sodonnel commented on a change in pull request #2590: HDDS-5689. chooseRandom in NetworkTopology should exclude the affinity node too

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2590:
URL: https://github.com/apache/ozone/pull/2590#discussion_r697284341



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetworkTopologyImpl.java
##########
@@ -514,6 +514,13 @@ private Node chooseNodeInternal(String scope, int leafIndex,
       List<String> excludedScopes, Collection<Node> excludedNodes,
       Node affinityNode, int ancestorGen) {
     Preconditions.checkArgument(scope != null);
+    LOG.debug("Start choosing node[scope = {}, index = {}, excludedScopes = {},"

Review comment:
       This log message needs wrapped in a `if LOG.isDebugEnabled()`, as there is a lot of evaluation in the parameters.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org