You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/10/18 19:13:59 UTC

[GitHub] [superset] suddjian commented on pull request #17145: refactor: dashboard->explore url generation

suddjian commented on pull request #17145:
URL: https://github.com/apache/superset/pull/17145#issuecomment-946083688


   The goal with moving from `POST` to an `<a>` link was to improve UX by allowing proper browser controls (such as "open in a new tab" vs in-tab navigation). It's usually good UX practice to navigate using links.
   
   I'd really like to understand better what the differences are between the POST solution and this one, to be able to solve your issues. The `getExploreLongUrl` function is also used by Explore to set the url, so presumably any issues with long urls would also apply there.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org