You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/03/09 20:39:35 UTC
[GitHub] [trafficcontrol] jrushford opened a new pull request #6628: Add TrafficOps login dispersion
jrushford opened a new pull request #6628:
URL: https://github.com/apache/trafficcontrol/pull/6628
Adds TrafficOps login dispersion
## Which Traffic Control components are affected by this PR?
- Traffic Control Health Client (tc-health-client)
## What is the best way to verify this PR?
<!-- Please include here ALL the steps necessary to test your PR.
If your PR has tests (and most should), provide the steps needed to run the tests.
If not, please provide step-by-step instructions to test the PR manually and explain why your PR does not need tests. -->
## PR submission checklist
- [x] This PR has tests <!-- If not, please delete this text and explain why this PR does not need tests. -->
- [x] This PR has documentation <!-- If not, please delete this text and explain why this PR does not need documentation. -->
- [x] This PR has a CHANGELOG.md entry <!-- A fix for a bug from an ATC release, an improvement, or a new feature should have a changelog entry. -->
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://apache.org/security) for details)
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp merged pull request #6628: Add TrafficOps login dispersion
Posted by GitBox <gi...@apache.org>.
rawlinp merged pull request #6628:
URL: https://github.com/apache/trafficcontrol/pull/6628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rawlinp commented on a change in pull request #6628: Add TrafficOps login dispersion
Posted by GitBox <gi...@apache.org>.
rawlinp commented on a change in pull request #6628:
URL: https://github.com/apache/trafficcontrol/pull/6628#discussion_r823106585
##########
File path: tc-health-client/README.md
##########
@@ -104,7 +104,7 @@ Sample configuarion file:
"to-request-timeout-seconds": "5s",
"tm-poll-interval-seconds": "60s",
"tm-proxy-url", "http://sample-http-proxy.cdn.net:80",
- "tm-update-cycles": 5,
+ "to-to-login-dispersion-factor": 90,
Review comment:
`to-to-login`, one `to` too many
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on pull request #6628: Add TrafficOps login dispersion
Posted by GitBox <gi...@apache.org>.
jrushford commented on pull request #6628:
URL: https://github.com/apache/trafficcontrol/pull/6628#issuecomment-1063459024
> just noticed this, since this is a long-running service, you can save the session and reuse it. That way it will reuse the cookie with every request, and if it gets 401'd due to the cookie expiring, the client will automatically try to login again to refresh it.
>
> As long as a request is made at least once an hour, the cookie should stay fresh too.
Thanks @rawlinp I was talking to @jpappa200 and he had added the cookie reuse in t3c, he was going to add it to the health-client as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] jrushford commented on a change in pull request #6628: Add TrafficOps login dispersion
Posted by GitBox <gi...@apache.org>.
jrushford commented on a change in pull request #6628:
URL: https://github.com/apache/trafficcontrol/pull/6628#discussion_r823114480
##########
File path: tc-health-client/README.md
##########
@@ -104,7 +104,7 @@ Sample configuarion file:
"to-request-timeout-seconds": "5s",
"tm-poll-interval-seconds": "60s",
"tm-proxy-url", "http://sample-http-proxy.cdn.net:80",
- "tm-update-cycles": 5,
+ "to-to-login-dispersion-factor": 90,
Review comment:
@rawlinp fixed it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org