You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@camel.apache.org by "Charles Moulliard (JIRA)" <ji...@apache.org> on 2009/03/09 16:37:39 UTC

[jira] Created: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

unmarshaling of data always send the last occurence of the stream
-----------------------------------------------------------------

                 Key: CAMEL-1442
                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
             Project: Apache Camel
          Issue Type: Bug
          Components: camel-bindy
    Affects Versions: 2.0-M1
            Reporter: Charles Moulliard


The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Moulliard updated CAMEL-1442:
-------------------------------------

    Attachment: crlf_noModelReset.patch

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Moulliard updated CAMEL-1442:
-------------------------------------

    Attachment: crlf_noModelReset.patch

- Class ConvertSeparator has been renamed into Converter
- A new property has been added to the annotations class : CsvRecord and MEssage : crlf. Three values can be used "WINDOWS", "UNIX" and "MAC"
- Marshall method uses this property to add CRLF after each record

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Charles Moulliard updated CAMEL-1442:
-------------------------------------

    Attachment:     (was: crlf_noModelReset.patch)

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50399#action_50399 ] 

Charles Moulliard commented on CAMEL-1442:
------------------------------------------

@All,

Camel-bindy wiki documentation has been updated.

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea reassigned CAMEL-1442:
--------------------------------------

    Assignee: Hadrian Zbarcea

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>            Assignee: Hadrian Zbarcea
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Claus Ibsen (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50391#action_50391 ] 

Claus Ibsen commented on CAMEL-1442:
------------------------------------

Charles could you make the CR LF configurable. What if end users just want unix format, mac format. eg only CR or LF

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50392#action_50392 ] 

Charles Moulliard commented on CAMEL-1442:
------------------------------------------

+1 Claus,

I will add new parameter in the annotation to define the character to be used for the carriage return/Line feed and extend the class ConvertSeparator





> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Hadrian Zbarcea (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hadrian Zbarcea resolved CAMEL-1442.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.0-M1

Patch applied with thanks.  Good work Charles.

I had to make a few changes because of some test issues.  For some Marshall tests he expected string did not end with "\r\n" but the crlf style was 'windows' so actuals differed from expected.  For some Unmarshall tests the exchange was ending up in the dlc because of an NPE in the Object.toString().  Modifying the code to String.valueOf(Object) fixes that.  There's a bit more that could be cleaned up for consistency, but these were the minimum changes to get the tests to pass.

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>            Assignee: Hadrian Zbarcea
>             Fix For: 2.0-M1
>
>         Attachments: crlf_noModelReset.patch
>
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CAMEL-1442) unmarshaling of data always send the last occurence of the stream

Posted by "Charles Moulliard (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/activemq/browse/CAMEL-1442?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=50390#action_50390 ] 

Charles Moulliard commented on CAMEL-1442:
------------------------------------------

and no carriage return (CRLF) was added after a record in the outputstream

> unmarshaling of data always send the last occurence of the stream
> -----------------------------------------------------------------
>
>                 Key: CAMEL-1442
>                 URL: https://issues.apache.org/activemq/browse/CAMEL-1442
>             Project: Apache Camel
>          Issue Type: Bug
>          Components: camel-bindy
>    Affects Versions: 2.0-M1
>            Reporter: Charles Moulliard
>
> The unmarshaling method of BindyDataFormat (CSV or Key Value Pair) does not create a new model object for each new line of the stream readed

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.