[GitHub] [iceberg] RussellSpitzer commented on a change in pull request #3292: Spark: Compact Medium Size Files (#460)

[GitBox <gi...@apache.org>]

RussellSpitzer commented on a change in pull request #3292:
URL: https://github.com/apache/iceberg/pull/3292#discussion_r762183359



##########
File path: api/src/main/java/org/apache/iceberg/FileFormat.java
##########
@@ -25,23 +25,29 @@
  * Enum of supported file formats.
  */
 public enum FileFormat {
-  ORC("orc", true),
-  PARQUET("parquet", true),
-  AVRO("avro", true),
-  METADATA("metadata.json", false);
+  ORC("orc", true, true),
+  PARQUET("parquet", true, true),
+  AVRO("avro", true, false),
+  METADATA("metadata.json", false, false);
 
   private final String ext;
   private final boolean splittable;
+  private final boolean offsets;
 
-  FileFormat(String ext, boolean splittable) {
+  FileFormat(String ext, boolean splittable, boolean offsets) {
     this.ext = "." + ext;
     this.splittable = splittable;
+    this.offsets = offsets;
   }
 
   public boolean isSplittable() {
     return splittable;
   }
 
+  public boolean hasOffsets() {
+    return offsets;

Review comment:
       To be clear, this is not treating every file the same but saying that this file has the potential of having offsets as opposed to being arbitrarily splittable. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org