[GitHub] [bookkeeper] eolivelli commented on a change in pull request #2319: Issue 2285: Spammy log when one bookie of ensemble is down

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #2319:
URL: https://github.com/apache/bookkeeper/pull/2319#discussion_r413522309



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClient.java
##########
@@ -2447,12 +2447,16 @@ public void operationComplete(ChannelFuture future) throws Exception {
                     Throwable cause = future.cause();
                     if (cause instanceof UnknownHostException || cause instanceof NativeIoException) {
                         // Don't log stack trace for common errors
-                        LOG.warn("Could not connect to bookie: {}/{}, current state {} : {}",

Review comment:
       If you remove this line how do you know that the client is not able to connect to the bookie?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org