You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2020/10/21 03:49:20 UTC

[GitHub] [ignite] aries-3 opened a new pull request #8383: IGNITE-13591 added metric LastCheckpointStart

aries-3 opened a new pull request #8383:
URL: https://github.com/apache/ignite/pull/8383


   Added methods for reading of new metrics:
    - DataStorageMetrics.getLastCheckpointStartDate()
    - DataStorageMetricsImpl.getLastCheckpointStartDate()
    - DataStorageMetricsMXBean.getLastCheckpointStartDate() 
    - DataStorageMetricsSnapshot.getLastCheckpointStartDate()
   
   Added metric registration:
    - DataStorageMetricsImpl (see class constructor)
   
   Added metric value update:
    - DataStorageMetricsImpl.onCheckpoint()
    - GridCacheDatabaseSharedManager.updateMetrics()


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] agura commented on a change in pull request #8383: IGNITE-13591 added metric LastCheckpointStart

Posted by GitBox <gi...@apache.org>.
agura commented on a change in pull request #8383:
URL: https://github.com/apache/ignite/pull/8383#discussion_r514519089



##########
File path: modules/core/src/main/java/org/apache/ignite/DataStorageMetrics.java
##########
@@ -98,6 +98,13 @@
      */
     public long getLastCheckpointDuration();
 
+    /**
+     * Start timestamp of the last checkpoint

Review comment:
       Please fix javadoc. It should describe what this method does. It is obviously that this method doesn't start anything. So correct comment should start with "Returns" and describe what exactly it returns. Also each sentence in javadoc must end with dot (.). Please fix it here and check the rest comment in your change.
   
   I believe also that time instead of timestamp is better word for an end-user. Again, here and in other changed lines.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] dspavlov closed pull request #8383: IGNITE-13591 added metric LastCheckpointStart

Posted by GitBox <gi...@apache.org>.
dspavlov closed pull request #8383:
URL: https://github.com/apache/ignite/pull/8383


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ignite] dspavlov commented on pull request #8383: IGNITE-13591 added metric LastCheckpointStart

Posted by GitBox <gi...@apache.org>.
dspavlov commented on pull request #8383:
URL: https://github.com/apache/ignite/pull/8383#issuecomment-894335651


   This PR is associated with a resolved ticket. Closing the PR, please reopen it if you still need it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org