You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2021/10/31 15:43:28 UTC
[GitHub] [activemq-artemis] Asukwo-comfort opened a new pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Asukwo-comfort opened a new pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
Issue link: https://issues.apache.org/jira/browse/ARTEMIS-3538
I have tried removing comments like the one below from these codebase:
// Constants -----------------------------------------------------
// Attributes ----------------------------------------------------
// Static --------------------------------------------------------
// Constructors --------------------------------------------------
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956491594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956240572
there's a merge commit on your Pull Request.
please rebase against main and push -f?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956426356
Is the force-pushed meant to close my pull request? I don't get why it keeps closing my pull request whenever a force-push
@clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958592329
Thank you so much @Asukwo-comfort ...I have merged your PR (with a rebase).
I found a few extra ones that I included on a separate commit.. Thank you so much for your collaboration.
This concludes the PR you need for your outreachy application. thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956491784
these are all regular git-fu (your knowledge on git)... rebasing, fixing conflicts.. etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958592329
Thank you so much @Asukwo-comfort ...I have merged your PR (with a rebase).
I found a few extra ones that I included on a separate commit.. Thank you so much for your collaboration.
This concludes the PR you need for your outreachy application. thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958592329
Thank you so much @Asukwo-comfort ...I have merged your PR (with a rebase).
I found a few extra ones that I included on a separate commit.. Thank you so much for your collaboration.
This concludes the PR you need for your outreachy application. thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956491594
@Asukwo-comfort you lost your commit in your git operations... you pretty much made a mistake.
I suggest you do a checkout from apache/main -B YOUR-branch
then I would cherry-pick the commit.
Fix the diffs...
and push -f
you need to rebase and fix the inconsistencies with main.
at least for now you can recover your previous branch by doing:
git reset 872e570
git push origin -f
Then you should checkout main:
git checkout main -B new-branch
and cherry-pick commit with the fix:
git cherry-pick 89253b8513d597af04c631ce0b32882113e5d84b
mixup the diffs...
and push -f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956491784
these are all regular git-fu... rebasing, fixing conflicts.. etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] clebertsuconic edited a comment on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
clebertsuconic edited a comment on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956491784
these are all regular git-fu (your knowledge on git)... rebasing, fixing conflicts.. etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort edited a comment on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort edited a comment on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956426356
Is the force-pushed meant to close my pull request? I don't get why it keeps closing my pull request whenever i force-push
@clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort edited a comment on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort edited a comment on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956426356
Is the force-pushed meant to close my pull request? I don't get why it keeps closing my pull request whenever i force-push
@clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-956426356
Is the force-pushed meant to close my pull request? I don't get why it keeps closing my pull request whenever a force-push
@clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958598012
@***@***.*** ***@***.***> I really appreciate
your effort in putting me through on this contribution. Though it actually
took me sometime to get to understand the codebase, i will love to keep
contributing to the project so i that i can learn in process, that's if you
don't mind
On Wed, Nov 3, 2021, 02:47 clebertsuconic ***@***.***> wrote:
> Thank you so much @Asukwo-comfort <https://github.com/Asukwo-comfort>
> ...I have merged your PR (with a rebase).
>
> I found a few extra ones that I included on a separate commit.. Thank you
> so much for your collaboration.
>
> This concludes the PR you need for your outreachy application. thank you
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958592329>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APNT4TWEENQ6HMG4FGIV5NLUKCPCRANCNFSM5HCNOMGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958365740
I have done the necessary fixes and added a new commit and force-pushed
@clebertsuconic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958598012
@***@***.*** ***@***.***> I really appreciate
your effort in putting me through on this contribution. Though it actually
took me sometime to get to understand the codebase, i will love to keep
contributing to the project so i that i can learn in process, that's if you
don't mind
On Wed, Nov 3, 2021, 02:47 clebertsuconic ***@***.***> wrote:
> Thank you so much @Asukwo-comfort <https://github.com/Asukwo-comfort>
> ...I have merged your PR (with a rebase).
>
> I found a few extra ones that I included on a separate commit.. Thank you
> so much for your collaboration.
>
> This concludes the PR you need for your outreachy application. thank you
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958592329>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APNT4TWEENQ6HMG4FGIV5NLUKCPCRANCNFSM5HCNOMGQ>
> .
> Triage notifications on the go with GitHub Mobile for iOS
> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
> or Android
> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
>
>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] Asukwo-comfort commented on pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
Asukwo-comfort commented on pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829#issuecomment-958365740
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [activemq-artemis] asfgit closed pull request #3829: ARTEMIS-3538: Removing // --------- comments from the codebase
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #3829:
URL: https://github.com/apache/activemq-artemis/pull/3829
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org