[GitHub] [zeppelin] Reamer commented on a diff in pull request #4545: CI broken

[GitBox <gi...@apache.org>]

Reamer commented on code in PR #4545:
URL: https://github.com/apache/zeppelin/pull/4545#discussion_r1064361473


##########
zeppelin-interpreter-shaded/pom.xml:
##########
@@ -33,7 +33,7 @@
   <description>Zeppelin Interpreter Shaded</description>
 
   <properties>
-    <shaded.dependency.prefix>org.apache.zeppelin.shaded</shaded.dependency.prefix>
+    <shaded.dependency.prefix>shaded</shaded.dependency.prefix>

Review Comment:
   > is it necessary? I believe it was fixed in 3.3.0 by [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252)
   
   I can't understand what [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) has to do with relocation of classes. In [MSHADE-252](https://issues.apache.org/jira/browse/MSHADE-252) it is about the correct generation of Java source files. There was even another issue [MSHADE-396](https://issues.apache.org/jira/browse/MSHADE-396) which I opened and closed with the help of @kriegaex.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org