You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Artem Harutyunyan <ar...@mesosphere.io> on 2015/11/12 19:10:52 UTC
Re: Review Request 40241: Fixed a bug with hanging editor reported by
Ben Mahler.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/
-----------------------------------------------------------
(Updated Nov. 12, 2015, 10:10 a.m.)
Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Repository: mesos
Description
-------
Fixed a bug with hanging editor reported by Ben Mahler.
Diffs
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/40241/diff/
Testing
-------
Thanks,
Artem Harutyunyan
Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit
editors from hanging.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/#review107981
-----------------------------------------------------------
Ship it!
Thanks for fixing this, I committed it without committing 40225 since they looked independent.
- Ben Mahler
On Nov. 14, 2015, 5:07 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40241/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2015, 5:07 p.m.)
>
>
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> `subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change.
>
>
> Diffs
> -----
>
> support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
>
> Diff: https://reviews.apache.org/r/40241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Harutyunyan
>
>
Re: Review Request 40241: Fixed apply-reviews.py to prevent git commit
editors from hanging.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 9:07 a.m.)
Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Summary (updated)
-----------------
Fixed apply-reviews.py to prevent git commit editors from hanging.
Repository: mesos
Description
-------
`subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change.
Diffs
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/40241/diff/
Testing
-------
Thanks,
Artem Harutyunyan
Re: Review Request 40241: Fixed a bug with hanging editor reported by
Ben Mahler.
Posted by Artem Harutyunyan <ar...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/
-----------------------------------------------------------
(Updated Nov. 14, 2015, 8:55 a.m.)
Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
Changes
-------
Addressed comments and fixed errors.
Repository: mesos
Description (updated)
-------
`subprocess.check_output()` used pipes to capture STDOUT and STDERR. Because of this certain editors (such as vi) would hang when invoked during git commit. To mitigate that I switched to `subprocess.call()` and did some code refactoring to accomodate that change.
Diffs (updated)
-----
support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
Diff: https://reviews.apache.org/r/40241/diff/
Testing
-------
Thanks,
Artem Harutyunyan
Re: Review Request 40241: Fixed a bug with hanging editor reported by
Ben Mahler.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40241/#review106429
-----------------------------------------------------------
support/apply-reviews.py (line 95)
<https://reviews.apache.org/r/40241/#comment165163>
i don't think CalledProcessError is raised for subprocess.call?
don't you want to print the output in case of error?
also, what exactly was the bug? can you add that to the description of this review?
- Vinod Kone
On Nov. 12, 2015, 6:10 p.m., Artem Harutyunyan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40241/
> -----------------------------------------------------------
>
> (Updated Nov. 12, 2015, 6:10 p.m.)
>
>
> Review request for mesos, Ben Mahler, Joris Van Remoortere, Joseph Wu, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a bug with hanging editor reported by Ben Mahler.
>
>
> Diffs
> -----
>
> support/apply-reviews.py d39ee9bb0ee782bd756b7a5fc0dec70d056c9589
>
> Diff: https://reviews.apache.org/r/40241/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Artem Harutyunyan
>
>