You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "wangsheng (Code Review)" <ge...@cloudera.org> on 2020/11/10 12:13:26 UTC

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg 

wangsheng has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16707


Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................

IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Iceberg already implements InputFormat/OutputFormat/SerDe in latest
version, so we need to update these classes in HdfsFileFormat.java,
more details can be found in:
https://github.com/apache/iceberg/blob/0.10.x/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
---
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
1 file changed, 3 insertions(+), 3 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/16707/1
-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7626/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 12:34:40 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16707/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/16707/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@67
PS3, Line 67: com.expediagroup.hiveberg.IcebergStorageHandler
This needs to be org.apache.iceberg.mr.hive.HiveIcebergStorageHandler



-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 10:32:02 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................

IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Iceberg already implements InputFormat/OutputFormat/SerDe in latest
version, so we need to update these classes in HdfsFileFormat.java
and HdfsStorageDescriptor.java, more details can be found in:
https://github.com/apache/iceberg/blob/0.10.x/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
---
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
3 files changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/16707/4
-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6644/


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 16:38:22 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 4:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6643/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:11:00 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................

IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Iceberg already implements InputFormat/OutputFormat/SerDe in latest
version, so we need to update these classes in HdfsFileFormat.java
and HdfsStorageDescriptor.java, more details can be found in:
https://github.com/apache/iceberg/blob/0.10.x/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
---
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
2 files changed, 4 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/07/16707/2
-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7631/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 02:07:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6638/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 15:09:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:18:26 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has removed a vote on this change.

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Removed Verified+1 by wangsheng <sk...@163.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16707/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java:

http://gerrit.cloudera.org:8080/#/c/16707/3/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@67
PS3, Line 67: org.apache.iceberg.mr.hive.HiveIcebergStorageHa
> This needs to be org.apache.iceberg.mr.hive.HiveIcebergStorageHandler
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:06:58 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 1: Code-Review+2

Thanks for fixing this!


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 15:08:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 2: Code-Review+2

The build failed due to out of memory, I opened IMPALA-10316 for this.


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 09:57:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 22:11:49 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6645/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 16:43:33 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 2:

(1 comment)

Thanks for review, Zoltan. I've already modify code, but dryrun task failed again. It seems unnecessary to Iceberg, here is some exception info:
10:35:39     '/home/ubuntu/Impala/testdata/bin/load_nested.py -t tpch_nested_orc_def -f orc/def' failed. Tail of log:
10:35:39 2020-11-11 02:35:06,225 INFO:load_nested[348]:Executing: 
10:35:39 
10:35:39       CREATE EXTERNAL TABLE supplier
10:35:39       STORED AS orc
10:35:39       TBLPROPERTIES('orc.compress' = 'ZLIB','external.table.purge'='TRUE')
10:35:39       AS SELECT * FROM tmp_supplier

And more details, please refer: https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/12588/console

http://gerrit.cloudera.org:8080/#/c/16707/1/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java:

http://gerrit.cloudera.org:8080/#/c/16707/1/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@75
PS1, Line 75: org.apache.iceberg.mr.hive.HiveIceberg
> This needs to be changed as well.
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 08:28:16 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6641/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 01:47:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6644/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:18:44 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "wangsheng (Code Review)" <ge...@cloudera.org>.
wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:23:19 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 4:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/7632/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 4
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:25:02 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 5: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 5
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 11:18:43 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................

IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Iceberg already implements InputFormat/OutputFormat/SerDe in latest
version, so we need to update these classes in HdfsFileFormat.java
and HdfsStorageDescriptor.java, more details can be found in:
https://github.com/apache/iceberg/blob/0.10.x/mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java

Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Reviewed-on: http://gerrit.cloudera.org:8080/16707
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/HdfsFileFormat.java
M fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
M fe/src/main/java/org/apache/impala/catalog/IcebergTable.java
3 files changed, 5 insertions(+), 5 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 6
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 1: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6638/


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 16:17:09 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/6641/


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 2
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 07:17:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/6642/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 09:58:53 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 3
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Reviewer: wangsheng <sk...@163.com>
Gerrit-Comment-Date: Wed, 11 Nov 2020 09:58:52 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/16707 )

Change subject: IMPALA-10315: Update 'ICEBERG' InputFormat/OutputFormat/SerDe from latest Iceberg
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16707/1/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java
File fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java:

http://gerrit.cloudera.org:8080/#/c/16707/1/fe/src/main/java/org/apache/impala/catalog/HdfsStorageDescriptor.java@75
PS1, Line 75: com.expediagroup.hiveberg.IcebergSerDe
This needs to be changed as well.



-- 
To view, visit http://gerrit.cloudera.org:8080/16707
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Icfc0c02942f91bc97f4b119425529435fa5f01c0
Gerrit-Change-Number: 16707
Gerrit-PatchSet: 1
Gerrit-Owner: wangsheng <sk...@163.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 10 Nov 2020 16:25:35 +0000
Gerrit-HasComments: Yes