[GitHub] rednaxelafx commented on issue #23303: [SPARK-26352][SQL] ReorderJoin should not change the order of output attributes

[GitBox <gi...@apache.org>]

rednaxelafx commented on issue #23303: [SPARK-26352][SQL] ReorderJoin should not change the order of output attributes
URL: https://github.com/apache/spark/pull/23303#issuecomment-447076314
 
 
   @gatorsmile that was my original intent. I only wanted to fix the non-CBO one in this PR originally, but after reading through the join reorder related test suite I found that most of them have both the non-CBO and the CBO one in the same `Optimize`. The test cases are going to fail one way or the other if we only fix one of them. Sadly we'll have to fix both in the same PR.
   
   The feature fix itself is really small, but granted it's in a very dense piece of code. The majority of this PR is actually about fixing the test cases....a lot of them were wrong to begin with (had incorrect output attribute order in the `expected` plans)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org