You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Leon (JIRA)" <ji...@apache.org> on 2011/08/31 16:04:10 UTC
[jira] [Created] (OFBIZ-4388) question to revision 1160539 "add the
viewsize and viewindex parameters to the buttons on a list form to remember
the paage and pagesize automatically"
question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
-------------------------------------------------------------------------------------------------------------------------------------------------------
Key: OFBIZ-4388
URL: https://issues.apache.org/jira/browse/OFBIZ-4388
Project: OFBiz
Issue Type: Bug
Components: framework
Affects Versions: SVN trunk
Reporter: Leon
I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4388) question to revision 1160539 "add
the viewsize and viewindex parameters to the buttons on a list form to
remember the paage and pagesize automatically"
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094565#comment-13094565 ]
Leon commented on OFBIZ-4388:
-----------------------------
IMHO, no matter what the reason is, it's not good idea to add these kind of parameter automatically. first, viewsize and view index are the params used in particular purpose, not all the form need them. second, if user need these params, they can add them themselves, what we need is to tell them how to.
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (OFBIZ-4388) question to revision
1160539 "add the viewsize and viewindex parameters to the buttons on a list
form to remember the paage and pagesize automatically"
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094583#comment-13094583 ]
Hans Bakker edited comment on OFBIZ-4388 at 8/31/11 2:57 PM:
-------------------------------------------------------------
every list with a button on the row level needs this. When the button is pressed and the viewindex and size is not remembered in the request the first page in the default size will be shown. There are many lists which have this problem.
I did not see anywhere in ofbiz where a button on the first list calls another list in OFBiz. can you provide an example where this happens? It could be easily solved on the second list by re-initialize these parameters there?
I was adding many viewindex/size parameters in listbuttons to make this work and this change will fix all lists.
was (Author: hansbak):
every list with a button on the row level needs this. most lists have at least a button. When the button is presses and the viewindex and size is not remembered in the request the first page in the default size will be shown.
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4388) question to revision 1160539 "add
the viewsize and viewindex parameters to the buttons on a list form to
remember the paage and pagesize automatically"
Posted by "Adrian Crum (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094571#comment-13094571 ]
Adrian Crum commented on OFBIZ-4388:
------------------------------------
The parameters need to be keyed to a specific form widget instance. There is an example of this in the screenlet widget expand/collapse implementation. Each screenlet has its own expand/collapse parameter.
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4388) question to revision 1160539 "add
the viewsize and viewindex parameters to the buttons on a list form to
remember the paage and pagesize automatically"
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094583#comment-13094583 ]
Hans Bakker commented on OFBIZ-4388:
------------------------------------
every list with a button on the row level needs this. most lists have at least a button. When the button is presses and the viewindex and size is not remembered in the request the first page in the default size will be shown.
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4388) question to revision 1160539 "add
the viewsize and viewindex parameters to the buttons on a list form to
remember the paage and pagesize automatically"
Posted by "Leon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13094624#comment-13094624 ]
Leon commented on OFBIZ-4388:
-----------------------------
Now I know why, thanks for explain.
There're two assumption in the reason you provide. One is the row level button rarely navigates to another list, the Second is the end user always want row level button submit go back to its original position. Such assumption are ok for application component, but not very safe for framework, especially for screen/form widget which is intensively used by others, not only in ofbiz itself, but also the customizaiton based on ofbiz.
At another point, why don't implement similar behavior to row level anchor link? From the view point of end user, is there any different between "post" by hidden-form and "get" by hyper link? (except the url shown on address bar of course. Actually, to avoid tedious url, we use hidden-form for low level button in many place in our customization, some of them do call another list)
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (OFBIZ-4388) question to revision 1160539 "add
the viewsize and viewindex parameters to the buttons on a list form to
remember the paage and pagesize automatically"
Posted by "Hans Bakker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-4388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13095078#comment-13095078 ]
Hans Bakker commented on OFBIZ-4388:
------------------------------------
Yes Leon I understand your problem., it is a trade-ff between having to specify the pagesize/index on every list button or not having to do this and having the annoyance when a new list is requested from the same button and have to re-init....
> question to revision 1160539 "add the viewsize and viewindex parameters to the buttons on a list form to remember the paage and pagesize automatically"
> -------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: OFBIZ-4388
> URL: https://issues.apache.org/jira/browse/OFBIZ-4388
> Project: OFBiz
> Issue Type: Bug
> Components: framework
> Affects Versions: SVN trunk
> Reporter: Leon
>
> I don't know why do that "automatically". This commit does break something. E.g. We have a list form which has hidden-form style button leads to another list form. If the former list is in page one, then everything works well, but if it's in page two, then you get nothing in latter list form because the "viewindex" of the first list is remembered and transited to the second.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira