You are viewing a plain text version of this content. The canonical link for it is here.
Posted to yarn-issues@hadoop.apache.org by "Morty Zhong (JIRA)" <ji...@apache.org> on 2018/12/11 09:51:00 UTC

[jira] [Updated] (YARN-9108) FederationIntercepter merge home and second response local variable spell mistake

     [ https://issues.apache.org/jira/browse/YARN-9108?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Morty Zhong updated YARN-9108:
------------------------------
    Description: 
method 'mergeAllocateResponse' in class FederationIntercepter.java line 1315

the left variable `par2` should be `par1`
{code:java}
if (par1 != null && par2 != null) {
  par1.getResourceRequest().addAll(par2.getResourceRequest());
  par2.getContainers().addAll(par2.getContainers());
}
{code}
should be
{code:java}
if (par1 != null && par2 != null) {
  par1.getResourceRequest().addAll(par2.getResourceRequest());
  par1.getContainers().addAll(par2.getContainers());//edited line
}
{code}

  was:
method 'mergeAllocateResponse' in class FederationIntercepter.java line 1315

the left variable `par2` should be `par1`
{code:java}
if (par1 != null && par2 != null) {
  par1.getResourceRequest().addAll(par2.getResourceRequest());
  par2.getContainers().addAll(par2.getContainers());
}
{code}
should be
{code:java}
if (par1 != null && par2 != null) {
  par1.getResourceRequest().addAll(par2.getResourceRequest());
  par1.getContainers().addAll(par2.getContainers());
}
{code}


> FederationIntercepter merge home and second response local variable spell mistake
> ---------------------------------------------------------------------------------
>
>                 Key: YARN-9108
>                 URL: https://issues.apache.org/jira/browse/YARN-9108
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: federation
>    Affects Versions: 3.3.0
>            Reporter: Morty Zhong
>            Priority: Minor
>
> method 'mergeAllocateResponse' in class FederationIntercepter.java line 1315
> the left variable `par2` should be `par1`
> {code:java}
> if (par1 != null && par2 != null) {
>   par1.getResourceRequest().addAll(par2.getResourceRequest());
>   par2.getContainers().addAll(par2.getContainers());
> }
> {code}
> should be
> {code:java}
> if (par1 != null && par2 != null) {
>   par1.getResourceRequest().addAll(par2.getResourceRequest());
>   par1.getContainers().addAll(par2.getContainers());//edited line
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org