[jira] [Commented] (MINIFICPP-443) Support GET requests in ListenHTTP and allow response body to be configured

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MINIFICPP-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16408896#comment-16408896 ] 

ASF GitHub Bot commented on MINIFICPP-443:
------------------------------------------

GitHub user achristianson opened a pull request:

    https://github.com/apache/nifi-minifi-cpp/pull/292

    MINIFICPP-443 Add support for GET requests in ListenHTTP and allow re…

    …sponse body to be configured
    
    Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced
         in the commit message?
    
    - [x] Does your PR title start with MINIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [x] If applicable, have you updated the LICENSE file?
    - [x] If applicable, have you updated the NOTICE file?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/achristianson/nifi-minifi-cpp MINIFICPP-443

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi-minifi-cpp/pull/292.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #292
    
----
commit a20f3671ceac4f069e98b5002b8b54412225b126
Author: Andrew I. Christianson <an...@...>
Date:   2018-03-22T01:20:54Z

    MINIFICPP-443 Add support for GET requests in ListenHTTP and allow response body to be configured

----


> Support GET requests in ListenHTTP and allow response body to be configured
> ---------------------------------------------------------------------------
>
>                 Key: MINIFICPP-443
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-443
>             Project: NiFi MiNiFi C++
>          Issue Type: Improvement
>            Reporter: Andrew Christianson
>            Assignee: Andrew Christianson
>            Priority: Major
>
> Currently GET requests are not supported with ListenHTTP. This limits functionality for no real reason. ListenHTTP should support GET requests where output FlowFiles have no content, but do have headers and query string information available.
> Additionally, the response body written by ListenHTTP is always empty. This should be configurable --preferably dynamically by using incoming FlowFiles with a type/purpose attribute.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)