[GitHub] [incubator-celeborn] zwangsheng commented on a diff in pull request #1563: [CELEBORN-653][TEST] Fix invalid configuration key in SparkTestBase

["zwangsheng (via GitHub)" <gi...@apache.org>]

zwangsheng commented on code in PR #1563:
URL: https://github.com/apache/incubator-celeborn/pull/1563#discussion_r1223753309


##########
tests/spark-it/src/test/scala/org/apache/celeborn/tests/spark/SparkTestBase.scala:
##########
@@ -45,20 +45,16 @@ trait SparkTestBase extends AnyFunSuite
     shutdownMiniCluster()
   }
 
-  def updateSparkConf(sparkConf: SparkConf, sort: Boolean): SparkConf = {
+  def updateSparkConf(sparkConf: SparkConf, shuffleWriteMode: String): SparkConf = {

Review Comment:
   How about using `ShuffleMode` enum for args type?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org