You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/22 15:23:34 UTC

[GitHub] [airflow] potiuk opened a new pull request #10477: Fixes quoting bug introduced in #10473

potiuk opened a new pull request #10477:
URL: https://github.com/apache/airflow/pull/10477


   Apparently GA does not like "" quotes for strings.
   
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on pull request #10477: Fixes quoting bug introduced in #10473

Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #10477:
URL: https://github.com/apache/airflow/pull/10477#issuecomment-678654711


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10477: Fixes quoting bug introduced in #10473

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10477:
URL: https://github.com/apache/airflow/pull/10477#issuecomment-678655428


   Just a note to anyone who makes a change to the 
   .github/workflows/build-images-workflow-run.yml" -> push it to master of your private repo before PR is opened those "workflow_run" types of workflows are only evaluated when they are in master (by design).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on pull request #10477: Fixes quoting bug introduced in #10473

Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #10477:
URL: https://github.com/apache/airflow/pull/10477#issuecomment-678654578


   This one needs to be merged without waiting - the quoting broke master build  (but it is only visible after merge because it concerns the workflow run build). 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk merged pull request #10477: Fixes quoting bug introduced in #10473

Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #10477:
URL: https://github.com/apache/airflow/pull/10477


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on pull request #10477: Fixes quoting bug introduced in #10473

Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #10477:
URL: https://github.com/apache/airflow/pull/10477#issuecomment-678655428


   Just a note to anyone who makes a change to the 
   .github/workflows/build-images-workflow-run.yml" -> push it to master of your private repo before PR is opened. 
   Those "workflow_run" types of workflows are only evaluated when they are in master (by design).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org