You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/03 08:29:37 UTC
[GitHub] [dubbo-go-pixiu] MasterKenway opened a new pull request #234: refactor: command dependence use spf13/cobra instead
MasterKenway opened a new pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
refactor command dependence
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-893196326
readme needed to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (68af1d6) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...68af1d6](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15708c4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...15708c4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (2500390) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 2500390 differs from pull request most recent head fac8030. Consider uploading reports for the commit fac8030 to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...fac8030](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks commented on a change in pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#discussion_r681698436
##########
File path: cmd/pixiu/control.go
##########
@@ -41,99 +45,108 @@ var (
"critical": "FATAL",
}
- cmdStart = cli.Command{
- Name: "start",
- Usage: "start dubbogo pixiu",
- Flags: []cli.Flag{
- cli.StringFlag{
- Name: "config, c",
- Usage: "Load configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_CONFIG",
- Value: "configs/conf.yaml",
- },
- cli.StringFlag{
- Name: "api-config, a",
- Usage: "Load api configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_API_CONFIG",
- Value: "configs/api_config.yaml",
- },
- cli.StringFlag{
- Name: "log-config, lc",
- Usage: "Load log configuration from `FILE`",
- EnvVar: "LOG_FILE",
- Value: "configs/log.yml",
- },
- cli.StringFlag{
- Name: "log-level, l",
- Usage: "dubbogo pixiu log level, trace|debug|info|warning|error|critical",
- EnvVar: "LOG_LEVEL",
- },
- cli.StringFlag{
- Name: "log-format, lf",
- Usage: "dubbogo pixiu log format, currently useless",
- },
- cli.StringFlag{
- Name: "limit-cpus, limc",
- Usage: "dubbogo pixiu schedule threads count",
- },
- },
- Action: func(c *cli.Context) error {
- configPath := c.String("config")
- apiConfigPath := c.String("api-config")
- flagLogLevel := c.String("log-level")
- logConfPath := c.String("log-config")
+ configPath string
+ apiConfigPath string
+ logConfigPath string
+ logLevel string
+
+ // CURRENTLY USELESS
+ logFormat string
+
+ limitCpus string
- err := logger.InitLog(logConfPath)
+ // Currently default set to false, wait for up coming support
+ initFromRemote = false
+
+ startCmd = &cobra.Command{
Review comment:
不要用 startCmd，改成 startGatewayCmd，启动命令改成 --start-gateway，为将来 sidecar 模式留下空间
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on a change in pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#discussion_r682214977
##########
File path: cmd/pixiu/control.go
##########
@@ -41,99 +45,108 @@ var (
"critical": "FATAL",
}
- cmdStart = cli.Command{
- Name: "start",
- Usage: "start dubbogo pixiu",
- Flags: []cli.Flag{
- cli.StringFlag{
- Name: "config, c",
- Usage: "Load configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_CONFIG",
- Value: "configs/conf.yaml",
- },
- cli.StringFlag{
- Name: "api-config, a",
- Usage: "Load api configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_API_CONFIG",
- Value: "configs/api_config.yaml",
- },
- cli.StringFlag{
- Name: "log-config, lc",
- Usage: "Load log configuration from `FILE`",
- EnvVar: "LOG_FILE",
- Value: "configs/log.yml",
- },
- cli.StringFlag{
- Name: "log-level, l",
- Usage: "dubbogo pixiu log level, trace|debug|info|warning|error|critical",
- EnvVar: "LOG_LEVEL",
- },
- cli.StringFlag{
- Name: "log-format, lf",
- Usage: "dubbogo pixiu log format, currently useless",
- },
- cli.StringFlag{
- Name: "limit-cpus, limc",
- Usage: "dubbogo pixiu schedule threads count",
- },
- },
- Action: func(c *cli.Context) error {
- configPath := c.String("config")
- apiConfigPath := c.String("api-config")
- flagLogLevel := c.String("log-level")
- logConfPath := c.String("log-config")
+ configPath string
+ apiConfigPath string
+ logConfigPath string
+ logLevel string
+
+ // CURRENTLY USELESS
+ logFormat string
+
+ limitCpus string
- err := logger.InitLog(logConfPath)
+ // Currently default set to false, wait for up coming support
+ initFromRemote = false
+
+ startCmd = &cobra.Command{
Review comment:
resolved
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d34f241) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...d34f241](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (19afc50) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...19afc50](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-893196326
readme needed to be updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15708c4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...15708c4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-893196326
~readme needed to be updated~ Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on a change in pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#discussion_r682214977
##########
File path: cmd/pixiu/control.go
##########
@@ -41,99 +45,108 @@ var (
"critical": "FATAL",
}
- cmdStart = cli.Command{
- Name: "start",
- Usage: "start dubbogo pixiu",
- Flags: []cli.Flag{
- cli.StringFlag{
- Name: "config, c",
- Usage: "Load configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_CONFIG",
- Value: "configs/conf.yaml",
- },
- cli.StringFlag{
- Name: "api-config, a",
- Usage: "Load api configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_API_CONFIG",
- Value: "configs/api_config.yaml",
- },
- cli.StringFlag{
- Name: "log-config, lc",
- Usage: "Load log configuration from `FILE`",
- EnvVar: "LOG_FILE",
- Value: "configs/log.yml",
- },
- cli.StringFlag{
- Name: "log-level, l",
- Usage: "dubbogo pixiu log level, trace|debug|info|warning|error|critical",
- EnvVar: "LOG_LEVEL",
- },
- cli.StringFlag{
- Name: "log-format, lf",
- Usage: "dubbogo pixiu log format, currently useless",
- },
- cli.StringFlag{
- Name: "limit-cpus, limc",
- Usage: "dubbogo pixiu schedule threads count",
- },
- },
- Action: func(c *cli.Context) error {
- configPath := c.String("config")
- apiConfigPath := c.String("api-config")
- flagLogLevel := c.String("log-level")
- logConfPath := c.String("log-config")
+ configPath string
+ apiConfigPath string
+ logConfigPath string
+ logLevel string
+
+ // CURRENTLY USELESS
+ logFormat string
+
+ limitCpus string
- err := logger.InitLog(logConfPath)
+ // Currently default set to false, wait for up coming support
+ initFromRemote = false
+
+ startCmd = &cobra.Command{
Review comment:
已更新，目前gateway模式启动命令为 ./dubb-go-pixiu startgateway [OPTIONS]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] AlexStocks merged pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3590d67) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...3590d67](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter commented on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15708c4) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...15708c4](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] codecov-commenter edited a comment on pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#issuecomment-891664444
# [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#234](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fac8030) into [develop](https://codecov.io/gh/apache/dubbo-go-pixiu/commit/71a2d604d7bba44452bb4b942b27c3983d732098?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (71a2d60) will **decrease** coverage by `0.07%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #234 +/- ##
===========================================
- Coverage 40.58% 40.50% -0.08%
===========================================
Files 39 39
Lines 2267 2264 -3
===========================================
- Hits 920 917 -3
Misses 1255 1255
Partials 92 92
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/logger/logger.go](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2xvZ2dlci9sb2dnZXIuZ28=) | `94.44% <100.00%> (-0.30%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [71a2d60...fac8030](https://codecov.io/gh/apache/dubbo-go-pixiu/pull/234?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-pixiu] MasterKenway commented on a change in pull request #234: refactor: command dependence use spf13/cobra instead
Posted by GitBox <gi...@apache.org>.
MasterKenway commented on a change in pull request #234:
URL: https://github.com/apache/dubbo-go-pixiu/pull/234#discussion_r682214977
##########
File path: cmd/pixiu/control.go
##########
@@ -41,99 +45,108 @@ var (
"critical": "FATAL",
}
- cmdStart = cli.Command{
- Name: "start",
- Usage: "start dubbogo pixiu",
- Flags: []cli.Flag{
- cli.StringFlag{
- Name: "config, c",
- Usage: "Load configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_CONFIG",
- Value: "configs/conf.yaml",
- },
- cli.StringFlag{
- Name: "api-config, a",
- Usage: "Load api configuration from `FILE`",
- EnvVar: "DUBBOGO_PIXIU_API_CONFIG",
- Value: "configs/api_config.yaml",
- },
- cli.StringFlag{
- Name: "log-config, lc",
- Usage: "Load log configuration from `FILE`",
- EnvVar: "LOG_FILE",
- Value: "configs/log.yml",
- },
- cli.StringFlag{
- Name: "log-level, l",
- Usage: "dubbogo pixiu log level, trace|debug|info|warning|error|critical",
- EnvVar: "LOG_LEVEL",
- },
- cli.StringFlag{
- Name: "log-format, lf",
- Usage: "dubbogo pixiu log format, currently useless",
- },
- cli.StringFlag{
- Name: "limit-cpus, limc",
- Usage: "dubbogo pixiu schedule threads count",
- },
- },
- Action: func(c *cli.Context) error {
- configPath := c.String("config")
- apiConfigPath := c.String("api-config")
- flagLogLevel := c.String("log-level")
- logConfPath := c.String("log-config")
+ configPath string
+ apiConfigPath string
+ logConfigPath string
+ logLevel string
+
+ // CURRENTLY USELESS
+ logFormat string
+
+ limitCpus string
- err := logger.InitLog(logConfPath)
+ // Currently default set to false, wait for up coming support
+ initFromRemote = false
+
+ startCmd = &cobra.Command{
Review comment:
已更新，目前gateway模式启动命令为 ./dubb-go-pixiu gateway start [OPTIONS]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org