You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directory.apache.org by peter royal <pr...@apache.org> on 2006/03/12 18:23:59 UTC

Re: svn commit: r385254 - in /directory/trunks/mina/core/src/main/java/org/apache/mina/filter/codec: ProtocolCodecFactory.java ProtocolCodecFilter.java demux/DemuxingProtocolCodecFactory.java demux/MessageDecoderFactory.java demux/MessageEncoderFactory.java

On Mar 12, 2006, at 1:08 AM, trustin@apache.org wrote:
>       * Returns a new (or reusable) instance of {@link  
> ProtocolEncoder} which
>       * encodes message objects into binary or protocol-specific data.
>       */
> -    ProtocolEncoder getEncoder();
> +    ProtocolEncoder getEncoder() throws Exception;
>
>      /**
>       * Returns a new (or reusable) instance of {@link  
> ProtocolDecoder} which
>       * decodes binary or protocol-specific data into message objects.
>       */
> -    ProtocolDecoder getDecoder();
> +    ProtocolDecoder getDecoder() throws Exception;

Performance will suck if shared instances are returned due to  
synchronization on the returned instances in the  
ProtocolCodecFilter... Unless the synchronization is removed, it  
would be unadvisable to return shared instances.

-pete (discovered this the hard way)

-- 
proyal@apache.org - http://fotap.org/~osi