You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@accumulo.apache.org by mikewalch <gi...@git.apache.org> on 2016/05/25 13:29:51 UTC
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
GitHub user mikewalch opened a pull request:
https://github.com/apache/accumulo/pull/101
ACCUMULO-4313 - Made several improvements to website:
* Put website in container
* Moved Accumulo logo to navbar
* Organized navbar
* Moved all ASF links to their own dropdown on right
* Added logo to home page and simplified text
* Reduced text in footer
* Put new window icons after links
* Renamed 'GitHub Issues' link in navbar to 'Pull Requests'
* Pages have a default font size of 14px rather 16px
* Sidebar with social links only visible on home page so
documentation fills page which improves readability
* Removed download link from sidebar and added to navbar
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mikewalch/accumulo website-updates
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/accumulo/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit a78b6af97c4d43a72a4583ac09b32bfefbba4abc
Author: Mike Walch <mw...@gmail.com>
Date: 2016-05-23T16:16:49Z
ACCUMULO-4313 - Made several improvements to website:
* Put website in container
* Moved Accumulo logo to navbar
* Organized navbar
* Moved all ASF links to their own dropdown on right
* Added logo to home page and simplified text
* Reduced text in footer
* Put new window icons after links
* Renamed 'GitHub Issues' link in navbar to 'Pull Requests'
* Pages have a default font size of 14px rather 16px
* Sidebar with social links only visible on home page so
documentation fills page which improves readability
* Removed download link from sidebar and added to navbar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64679826
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
> I added the trademark to the main page using a front matter variable in 5d11346. Does this work?
This looks great to me. I appreciate you being flexible.
> Is this even required?
tl;dr Given my current understanding, yes.
I think this is something that @billierinaldi and I had recently added to the website specifically to meet the branding requirements that the ASF sets forward. See http://www.apache.org/foundation/marks/pmcs.html#attributions:
> All project or product homepages must feature a prominent trademark attribution of all applicable Apache trademarks. Other project pages should feature attributions of any marks displayed thereon.
Policy aside, I believe reminding visitors of the website that all of these names (*full* names, even) are trademarks of the ASF and deserve proper attribution is a worthwhile goal. It really doesn't strike me as intrusive or distracting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64605620
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
I was trying to reduce the legalese in the footer as its on every page. However, I see your point that it should be on the website somewhere. I pushed another commit ( ff8f675615 ) where I created a notice page. This is now linked to in the footer. Any additional legal notices can be added here rather than putting them in the footer. Does that work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64598028
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
Did you move this block about trademarks somewhere? It looks like it was deleted -- we definitely do not want to do that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/101#issuecomment-221917395
I addressed all of @ctubbsii cons except for moving the social buttons to the footer. While I agree with his view, this pull request is getting big enough. It should be fixed in a separate issue which I will create.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on the pull request:
https://github.com/apache/accumulo/pull/101#issuecomment-221920050
Created new issues for social buttons https://issues.apache.org/jira/browse/ACCUMULO-4316
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by joshelser <gi...@git.apache.org>.
Github user joshelser commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64606336
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
I think we should still have the legalese on the index page as it is expected to be present. We probalby don't need it in every footer. Maybe we can include that "partial" (I forget what Jekyll calls it) in the footer just on the index page?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64639825
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
Is this even required? It's messy to have it and is cleaner without, and I'm skeptical that it actually does anything to further protect the Apache brand (we already have "Apache" prefixes everwhere). So, if it's not required (and I can't find anything that says it is), I'd prefer it trimmed down.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/accumulo/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by ctubbsii <gi...@git.apache.org>.
Github user ctubbsii commented on the pull request:
https://github.com/apache/accumulo/pull/101#issuecomment-221692951
Spoke with Mike and made some suggestions. In summary:
Pros
* I like the improvements to the menu layout.
* I like the simplified footer.
* I like the image being moved into the menu.
* I like the removal of the search box. It wasn't very useful, I think.
* I like the removal of the left side social buttons on most pages.
Cons
* I don't think the index.md file needs to be renamed to index.html. It's still being processed as a Markdown file, because it has front-matter. Best to keep the filename consistency, I think, even if it currently doesn't contain markdown syntax. (Also easier to see the diff.)
* Menu doesn't resize quickly enough to the "mobile" view when the window shrinks. Might be best to shorten "Apache Software Foundation" or shrink the text size or something.
* "Apache License, Version 2.0" needs non-breaking spaces ` ` so it doesn't get broken up when window shrinks.
* I think the left-side social buttons shouldn't appear on the first page either. Instead, it should be moved to the footer. Or, at the very least, they should be made smaller without the large text next to them (hover text is sufficient).
* Nav bar getting bigger by X pixels means that the `h1::before`, etc. style needs to also increase by X pixels so section headers don't get hidden under the menu when navigating directly to a section.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] accumulo pull request: ACCUMULO-4313 - Made several improvements t...
Posted by mikewalch <gi...@git.apache.org>.
Github user mikewalch commented on a diff in the pull request:
https://github.com/apache/accumulo/pull/101#discussion_r64612755
--- Diff: _includes/footer.md ---
@@ -4,10 +4,7 @@
[![Apache Software Foundation][ASF_IMG]{: #asf-logo height="100"}][ASF]
Copyright © 2011-{{ site.time | date: '%Y' }} The Apache Software
-Foundation, Licensed under the [Apache License, Version 2.0][AL2]. Apache
--- End diff --
I added the trademark to the main page using a front matter variable in 5d113467a12. Does this work?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---