You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by wraydulany <gi...@git.apache.org> on 2016/09/27 18:12:47 UTC
[GitHub] incubator-pirk pull request #104: [Pirk-65] Debug Logging Not Working within...
GitHub user wraydulany opened a pull request:
https://github.com/apache/incubator-pirk/pull/104
[Pirk-65] Debug Logging Not Working within Distributed Applications
Fixes distributed logging.
In order to do so, we need to use the log4j2-1.2 bridge, and reassert our own log4j properties after hadoop/yarn start. We also need to make sure that our log4j1-style properties file is *not* named log4j.properties, as that name is eaten by hadoop because hadoop has a file of the same name earlier in the classpath than our properties file.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wraydulany/incubator-pirk PIRK-65
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-pirk/pull/104.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #104
----
commit b64a4157a79e191c1d8046593331e8553a89ef16
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T14:34:33Z
Update pom to include the log4j2-1.2 api bridge.
commit c5bc85019786d42cf5801342900d36244aca454d
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T14:36:42Z
Add a line to pirk.properties for mylog4j.properties.
commit 1313f720646fb87b120394c973793e5fd830ad19
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T15:09:51Z
Added pirklog4j.properties; updated pirk.properties to reflect this fact.
commit d44dc552702082cc7403a3f2d462476e1a15e0c5
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T15:10:19Z
Oh, should actually add the pirklog4j.properties file.
commit 4ded20cd8b4198560f65a58b19b109773b8713c6
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T15:17:00Z
Ammend SystemConfiguration to reassert log4j settings.
commit bb85c660abd1bac2cd2cdd6823d405e2ddfca25c
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T15:17:55Z
Added the LogUtils file.
commit 447880d9bb860f5545f44fbb8db5e2611b1b001e
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-26T16:33:08Z
remove test line.
commit d0cdf7edd8e3db6b6b23cf2fdf8d479bf610c17e
Author: Walter Ray-Dulany <ra...@gmail.com>
Date: 2016-09-27T18:06:52Z
Didn't need line about LOG_PROPERIES_FILE in SystemConfiguration
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-pirk issue #104: [Pirk-65] Debug Logging Not
Working within Distri...
Posted by Walter Ray-Dulany <ra...@apache.org>.
I suspect that the problems you were having are because this solution
relies on having two distinct log4j settings files, one which is ignored in
the distributed setting and the other of which is ignored in the standalone
setting.
To put it mildly, this 'solution' (and it's mine, so I feel fine
trash-talking it) is poor.
I propose that we roll back from log4j2 to log4j1, keeping slf4j. Thoughts?
On Tue, Sep 27, 2016 at 9:45 PM, ellisonanne <gi...@git.apache.org> wrote:
> Github user ellisonanne commented on the issue:
>
> https://github.com/apache/incubator-pirk/pull/104
>
> Can't seem to get the debug to work even in the local tests (?) Didn't
> try to troubleshoot more than a couple of minutes. What log settings are
> you using to test the debug?
>
> Are we making the decision to role back to a .properties file instead
> of a .xml file for the logging properties?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-pirk issue #104: [Pirk-65] Debug Logging Not Working within Distri...
Posted by ellisonanne <gi...@git.apache.org>.
Github user ellisonanne commented on the issue:
https://github.com/apache/incubator-pirk/pull/104
Can't seem to get the debug to work even in the local tests (?) Didn't try to troubleshoot more than a couple of minutes. What log settings are you using to test the debug?
Are we making the decision to role back to a .properties file instead of a .xml file for the logging properties?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-pirk issue #104: [Pirk-65] Debug Logging Not
Working within Distri...
Posted by Ellison Anne Williams <ea...@apache.org>.
I recall that it was tested at the time of merge.
However, for the last month or so, the distributed logging has seemed to
stop working - don't know what caused it or at what point (unfortunately, I
don't think that we were checking the distributed logging for seemingly
unrelated PRs). Walter seems to have concluded that we need to provide a
log4j - log4j2 bridge, which complicates matters. It seems that it would be
simpler just to roll back (vs. use the bridge) unless folks would like to
dig in further.
On Thu, Sep 29, 2016 at 4:15 PM, smarthi <gi...@git.apache.org> wrote:
> Github user smarthi commented on the issue:
>
> https://github.com/apache/incubator-pirk/pull/104
>
> @ellisonanne didn't we test this in distributed mode IIRC when we
> retired the old LogUtils and moved to slf4j ?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] incubator-pirk issue #104: [Pirk-65] Debug Logging Not Working within Distri...
Posted by smarthi <gi...@git.apache.org>.
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/104
@ellisonanne didn't we test this in distributed mode IIRC when we retired the old LogUtils and moved to slf4j ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---