You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Rodoni (Code Review)" <ge...@cloudera.org> on 2018/04/16 21:25:53 UTC
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Alex Rodoni has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10080
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Cherry-picks: not for 2.x.
---
M docs/topics/impala_upgrading.xml
1 file changed, 128 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10080/1
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Sailesh Mukil, Alex Behm, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10080
to look at the new patch set (#4).
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Cherry-picks: not for 2.x.
---
M docs/topics/impala_upgrading.xml
1 file changed, 158 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10080/4
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@150
PS3, Line 150: identifier, e.g. a table name, enclose the word in quotes.
enclose the word in backticks.
(*not* quotes)
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@155
PS3, Line 155: startup flag: <codeph>--reserved_words_version=2.11.0</codeph>.
Note that this startup option will eventually be deprecated.
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@184
PS3, Line 184: To conform to the SQL standard, Impala no longer performs alias
probably better to just link to the documentation and not repeat all examples here
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@190
PS3, Line 190: For example, the following statements will result in syntax errors.
They will not result in syntax errors, but error in semantic analysis (probably better to not list the examples here)
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@234
PS3, Line 234: The <codeph>PARQUET_ARRAY_RESOLUTION</codeph> query option controls
Remove this paragraph and merge the last sentence linking to the query options docu page with the paragraph in 230?
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@247
PS3, Line 247: >clustered</keyword> hint is enabled by default. The hint inserts a
The hint adds a local sort...
(better to not use "insert" since it could be misunderstood)
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 22:01:33 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Sailesh Mukil, Alex Behm, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10080
to look at the new patch set (#3).
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Cherry-picks: not for 2.x.
---
M docs/topics/impala_upgrading.xml
1 file changed, 187 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10080/3
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 2:
Does anyone have any comment? Is this ready to be merged?
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 01:32:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Vuk Ercegovac (Code Review)" <ge...@cloudera.org>.
Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 1:
(12 comments)
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@149
PS1, Line 149: you
is "you" the style used throughout the docs for such cases? seems a bit too informal.
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@151
PS1, Line 151: startup option, <codeph>reserved_words_version</codeph>, to
: <codeph>"2.11.0"</codeph>.
If this is a flag that's passed to the binary, lets call it a flag, along with making it look like a flag, e.g.: "--reserved_words_version=2.11.0"
Would that be consistent with other "startup options"?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@157
PS1, Line 157: /></title>
single line
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@159
PS1, Line 159: implementation
implementations
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@163
PS1, Line 163: you
"you"?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@164
PS1, Line 164: your
your?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@165
PS1, Line 165: <codeph>DECIMAL_V2</codeph> query option to
: <codeph>FALSE</codeph>.
just asking, do we typically provide the "set" command for these cases so its easy to cut-and-paste?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@188
PS1, Line 188: > 3;</codeblock>
is it worth pointing out the error message?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@211
PS1, Line 211: <p> The default value for the <codeph>PARQUET_ARRAY_RESOLUTION</codeph>
the query option?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@213
PS1, Line 213: Parquet standard 3-level
: encoding.
external link to this?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@219
PS1, Line 219: for the information about the query option.</p>
is it obvious what happens here if I don't think much about this change? in other words, should I expect some files to no longer be read, expect additional files to be read, or something else?
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@226
PS1, Line 226: >clustered</keyword> hint is enabled by default. The hint inserts a
fix break
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 22:11:51 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Cherry-picks: not for 2.x.
Reviewed-on: http://gerrit.cloudera.org:8080/10080
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M docs/topics/impala_upgrading.xml
1 file changed, 158 insertions(+), 2 deletions(-)
Approvals:
Alex Behm: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 5
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Hello Philip Zeyliger, Sailesh Mukil, Impala Public Jenkins, Vuk Ercegovac,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/10080
to look at the new patch set (#2).
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Cherry-picks: not for 2.x.
---
M docs/topics/impala_upgrading.xml
1 file changed, 160 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/80/10080/2
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10080/2/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/2/docs/topics/impala_upgrading.xml@288
PS2, Line 288: </conbody>
> Another important upgrade consideration is with the new fine-grained permis
Done
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 20:47:14 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 3:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@150
PS3, Line 150: identifier, e.g. a table name, enclose the word in quotes.
> enclose the word in backticks.
Done
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@155
PS3, Line 155: startup flag: <codeph>--reserved_words_version=2.11.0</codeph>.
> Note that this startup option will eventually be deprecated.
Done
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@184
PS3, Line 184: To conform to the SQL standard, Impala no longer performs alias
> probably better to just link to the documentation and not repeat all exampl
Done
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@190
PS3, Line 190: For example, the following statements will result in syntax errors.
> They will not result in syntax errors, but error in semantic analysis (prob
Done
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@234
PS3, Line 234: The <codeph>PARQUET_ARRAY_RESOLUTION</codeph> query option controls
> Remove this paragraph and merge the last sentence linking to the query opti
Done
http://gerrit.cloudera.org:8080/#/c/10080/3/docs/topics/impala_upgrading.xml@247
PS3, Line 247: >clustered</keyword> hint is enabled by default. The hint inserts a
> The hint adds a local sort...
Done
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 3
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 22:33:12 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/10080/2/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/2/docs/topics/impala_upgrading.xml@288
PS2, Line 288: </conbody>
Another important upgrade consideration is with the new fine-grained permissions. In particular, running REFRESH or INVALIDATE METADATA now requires a special privilege. Since the REFRESH privilege is a new privilege it should be noted that users that did not previously have ALL will no longer be able to run REFRESH or INVALIDATE METADATA after an upgrade.
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 2
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 04:45:41 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 4: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Fri, 20 Apr 2018 00:04:11 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 4: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 23:50:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-docs-submit/255/
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 4
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Thu, 19 Apr 2018 23:53:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@151
PS1, Line 151: startup option, <codeph>reserved_words_version</codeph>, to
: <codeph>"2.11.0"</codeph>.
> If this is a flag that's passed to the binary, lets call it a flag, along w
Done
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@157
PS1, Line 157: /></title>
> single line
Done
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@159
PS1, Line 159: implementation
> implementations
Done
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@188
PS1, Line 188: > 3;</codeblock>
> is it worth pointing out the error message?
It says you would get a syntax error above.
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 23:33:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
Posted by "Alex Rodoni (Code Review)" <ge...@cloudera.org>.
Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10080 )
Change subject: IMPALA-6860: [DOCS] Upgrade considerations for Impala 3.0
......................................................................
Patch Set 1:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml
File docs/topics/impala_upgrading.xml:
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@149
PS1, Line 149: you
> is "you" the style used throughout the docs for such cases? seems a bit too
"You" is very well adapted and highly endorsed style in tech writing
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@163
PS1, Line 163: you
> "you"?
See above
http://gerrit.cloudera.org:8080/#/c/10080/1/docs/topics/impala_upgrading.xml@164
PS1, Line 164: your
> your?
See above
--
To view, visit http://gerrit.cloudera.org:8080/10080
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If8416ac0abb7ea1b918ba53b9533af27182fbe89
Gerrit-Change-Number: 10080
Gerrit-PatchSet: 1
Gerrit-Owner: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Alex Rodoni <ar...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sa...@cloudera.com>
Gerrit-Reviewer: Vuk Ercegovac <ve...@cloudera.com>
Gerrit-Comment-Date: Mon, 16 Apr 2018 22:36:11 +0000
Gerrit-HasComments: Yes