You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/10/22 16:05:30 UTC

[GitHub] [pinot] walterddr commented on a diff in pull request #9630: [multistage] [debugability] Support explain distributed stage plan and add a test for explicit distinct

walterddr commented on code in PR #9630:
URL: https://github.com/apache/pinot/pull/9630#discussion_r1002516823


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/plan/DistributedStagePlan.java:
##########
@@ -73,4 +74,9 @@ public void setServerInstance(ServerInstance serverInstance) {
   public void setStageRoot(StageNode stageRoot) {
     _stageRoot = stageRoot;
   }
+
+  public String explain() {
+    return ExplainPlanStageVisitor.explainFrom(_metadataMap, _stageRoot, _serverInstance);

Review Comment:
   this shouldn't be used by this visitor pattern as there's nothing to visit 



##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/ExplainPlanStageVisitor.java:
##########
@@ -44,7 +44,7 @@
  */
 public class ExplainPlanStageVisitor implements StageNodeVisitor<StringBuilder, ExplainPlanStageVisitor.Context> {
 
-  private final QueryPlan _queryPlan;

Review Comment:
   why are we changing explain plan stage visitor? this should not be used by distributed stage plan as it already doesn't contain the query plan



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org