You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/06/08 13:19:00 UTC
[jira] [Updated] (HDDS-5303) OzoneDelegationTokenSecretManager
breaks the interface contract of S3SecretManager
[ https://issues.apache.org/jira/browse/HDDS-5303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated HDDS-5303:
---------------------------------
Labels: pull-request-available (was: )
> OzoneDelegationTokenSecretManager breaks the interface contract of S3SecretManager
> ----------------------------------------------------------------------------------
>
> Key: HDDS-5303
> URL: https://issues.apache.org/jira/browse/HDDS-5303
> Project: Apache Ozone
> Issue Type: Bug
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Trivial
> Labels: pull-request-available
>
> S3SecretManager is a generic interface which supposed to return with the secret key for one specific AWS access key id.
> It's a generic interface which may have multiple implementation.
> Unfortunately, it's not possible to use any implementation as OzoneDelegationTokenSecretManager does an explicit cast to retrieve the MetadataManager.
> Instead of breaking the abstract contract of interface it seems to be better to directly inject the required MetadataManager to the OzoneDelegationTokenSecretManager which makes it possible to use an implementation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org