You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2015/09/22 08:18:58 UTC
Review Request 38609: Refactored http::internal::request to use
http::connect.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone.
Repository: mesos
Description
-------
This gets rid of the duplicated code, in favor of leveraging http::Connection.
Diffs
-----
3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
Diff: https://reviews.apache.org/r/38609/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38609: Refactored http::internal::request to use
http::connect.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/#review101185
-----------------------------------------------------------
Patch looks great!
Reviews applied: [38595, 38596, 38597, 38598, 38600, 38599, 38601, 38603, 38604, 38605, 38606, 38607, 38608, 38609]
All tests passed.
- Mesos ReviewBot
On Oct. 1, 2015, 12:19 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38609/
> -----------------------------------------------------------
>
> (Updated Oct. 1, 2015, 12:19 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gets rid of the duplicated code, in favor of leveraging http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
> 3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
>
> Diff: https://reviews.apache.org/r/38609/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38609: Refactored http::internal::request to use
http::connect.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/
-----------------------------------------------------------
(Updated Oct. 1, 2015, 12:19 a.m.)
Review request for mesos, Jie Yu and Vinod Kone.
Changes
-------
Rebase.
Repository: mesos
Description
-------
This gets rid of the duplicated code, in favor of leveraging http::Connection.
Diffs (updated)
-----
3rdparty/libprocess/include/process/http.hpp ba3f0bc7df33795e332c374fbad04106b9d56416
3rdparty/libprocess/src/http.cpp d9925333f25491f92495bf11315237f54a0a2015
Diff: https://reviews.apache.org/r/38609/diff/
Testing
-------
make check
Thanks,
Ben Mahler
Re: Review Request 38609: Refactored http::internal::request to use
http::connect.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/#review99956
-----------------------------------------------------------
Bad patch!
Reviews applied: [38595, 38596, 38597, 38598, 38600, 38599]
Failed command: ./support/apply-review.sh -n -r 38599
Error:
2015-09-22 09:17:58 URL:https://reviews.apache.org/r/38599/diff/raw/ [11633/11633] -> "38599.patch" [1]
error: src/slave/containerizer/provisioners/docker/registry_client.cpp: does not exist in index
Failed to apply patch
- Mesos ReviewBot
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38609/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gets rid of the duplicated code, in favor of leveraging http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
> 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
>
> Diff: https://reviews.apache.org/r/38609/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>
Re: Review Request 38609: Refactored http::internal::request to use
http::connect.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38609/#review101060
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Sept. 22, 2015, 6:18 a.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38609/
> -----------------------------------------------------------
>
> (Updated Sept. 22, 2015, 6:18 a.m.)
>
>
> Review request for mesos, Jie Yu and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This gets rid of the duplicated code, in favor of leveraging http::Connection.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/http.hpp fbd6cf7967173495875a8ea90ed28ade88b982a2
> 3rdparty/libprocess/src/http.cpp 9ad613a16c379b6d76a9a0f8d6160fe23a182fd4
>
> Diff: https://reviews.apache.org/r/38609/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ben Mahler
>
>