You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/23 10:24:39 UTC

[GitHub] [flink] aljoscha commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support

aljoscha commented on issue #9720: [FLINK-13025] Elasticsearch 7.x support
URL: https://github.com/apache/flink/pull/9720#issuecomment-534041797
 
 
   I had a cursory glance at this. The code seems fine, because it's basically the ES 6 code. I have some general comments:
   
   - I don't think the ES connectors (both 6 and 7) need the Table Planner dependency anymore. Maybe @twalthr can confirm this, but you can also try removing them and seeing what happens.
   - I don't think we need Table-specific code in the connectors when there is the `flink-sql-connector-elasticsearch7` module. Maybe the Table-related code can be moved to that module, along with the tests.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services