You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/03/18 17:07:02 UTC

[GitHub] [zookeeper] jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor

jhuan31 commented on a change in pull request #855: ZOOKEEPER-3310: Add metrics for prep processor
URL: https://github.com/apache/zookeeper/pull/855#discussion_r266547276
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/PrepRequestProcessor.java
 ##########
 @@ -183,10 +186,12 @@ private ChangeRecord getOutstandingChange(String path) {
         }
     }
 
-    private void addChangeRecord(ChangeRecord c) {
-        synchronized (zks.outstandingChanges) {
-            zks.outstandingChanges.add(c);
-            zks.outstandingChangesForPath.put(c.path, c);
+    protected void addChangeRecord(ChangeRecord c) {
+        LOG.info("addChangeRecord called");
 
 Review comment:
   yes. will do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services