You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/10/29 18:40:42 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on issue #8464:
[SIP-15] Fixing datetime conversion and SQL literal
codecov-io edited a comment on issue #8464: [SIP-15] Fixing datetime conversion and SQL literal
URL: https://github.com/apache/incubator-superset/pull/8464#issuecomment-547571294
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=h1) Report
> Merging [#8464](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/8b74745f9e0d77eea373b9f9f5908f83bda3caa8?src=pr&el=desc) will **increase** coverage by `4.91%`.
> The diff coverage is `43.47%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #8464 +/- ##
==========================================
+ Coverage 66.56% 71.47% +4.91%
==========================================
Files 449 117 -332
Lines 22567 12330 -10237
Branches 2367 0 -2367
==========================================
- Hits 15021 8813 -6208
+ Misses 7408 3517 -3891
+ Partials 138 0 -138
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `90% <ø> (+4.28%)` | :arrow_up: |
| [superset/db\_engine\_specs/mssql.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL21zc3FsLnB5) | `48.83% <11.11%> (-9.5%)` | :arrow_down: |
| [superset/db\_engine\_specs/oracle.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL29yYWNsZS5weQ==) | `66.66% <25%> (-25%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `22.43% <25%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `27.85% <25%> (ø)` | :arrow_up: |
| [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `59.09% <33.33%> (-5.91%)` | :arrow_down: |
| [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `43.83% <33.33%> (-1.24%)` | :arrow_down: |
| [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `57.14% <40%> (+3.29%)` | :arrow_up: |
| [superset/db\_engine\_specs/clickhouse.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NsaWNraG91c2UucHk=) | `62.5% <40%> (+2.5%)` | :arrow_up: |
| [superset/db\_engine\_specs/elasticsearch.py](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2VsYXN0aWNzZWFyY2gucHk=) | `81.25% <40%> (ø)` | :arrow_up: |
| ... and [339 more](https://codecov.io/gh/apache/incubator-superset/pull/8464/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=footer). Last update [8b74745...fa2d521](https://codecov.io/gh/apache/incubator-superset/pull/8464?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org