You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/23 19:21:39 UTC
[GitHub] [airflow] potiuk opened a new pull request #7845: Skip Installation
on Travis
potiuk opened a new pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7845: Skip
Installation on Travis
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845#discussion_r396706277
##########
File path: .travis.yml
##########
@@ -149,6 +149,7 @@ jobs:
INSTALL_AIRFLOW_VERSION="1.10.6"
stage: test
script: ./scripts/ci/ci_prepare_and_test_backport_packages.sh
+install: skip
Review comment:
:man_facepalming:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7845: Skip
Installation on Travis
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845#discussion_r396704777
##########
File path: .travis.yml
##########
@@ -149,6 +149,7 @@ jobs:
INSTALL_AIRFLOW_VERSION="1.10.6"
stage: test
script: ./scripts/ci/ci_prepare_and_test_backport_packages.sh
+install: skip
Review comment:
got it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on a change in pull request #7845: Skip
Installation on Travis
Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845#discussion_r396700417
##########
File path: .travis.yml
##########
@@ -149,6 +149,7 @@ jobs:
INSTALL_AIRFLOW_VERSION="1.10.6"
stage: test
script: ./scripts/ci/ci_prepare_and_test_backport_packages.sh
+install: skip
Review comment:
sry, what are we skipping here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk commented on a change in pull request #7845: Skip
Installation on Travis
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845#discussion_r396703628
##########
File path: .travis.yml
##########
@@ -149,6 +149,7 @@ jobs:
INSTALL_AIRFLOW_VERSION="1.10.6"
stage: test
script: ./scripts/ci/ci_prepare_and_test_backport_packages.sh
+install: skip
Review comment:
Sorry that was quick. I had no time for explanation. I realized our build started to take long time.... and it turned out Travis is trying to be smart and when it sees requirements.txt it tries to install it automatically in the host...
That's what we are skipping :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] potiuk merged pull request #7845: Skip Installation on
Travis
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #7845: Skip Installation on Travis
URL: https://github.com/apache/airflow/pull/7845
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services