You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2014/12/23 00:54:42 UTC
Review Request 29337: Launch docker container and log through docker
executor.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/
-----------------------------------------------------------
Review request for mesos and Benjamin Hindman.
Repository: mesos-git
Description
-------
Launch docker container and log through docker executor.
Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
Diffs
-----
src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28
src/docker/docker.cpp 3a485a28d4b1ac3fcbce2e89c7d52b097886921a
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e
Diff: https://reviews.apache.org/r/29337/diff/
Testing
-------
make check.
Thanks,
Timothy Chen
Re: Review Request 29337: Launch docker container and log through
docker executor.
Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/#review69545
-----------------------------------------------------------
src/docker/executor.cpp
<https://reviews.apache.org/r/29337/#comment114231>
grammar
src/docker/executor.cpp
<https://reviews.apache.org/r/29337/#comment114232>
"mapped in" -> "mapped into". Otherwise I would not know what it could possibly mean.
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29337/#comment114234>
This can be factored out. We have closures...
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29337/#comment114235>
What's the reason for this timed waiting? Hacky stuff like this deserves an explanation in a comment.
src/tests/docker_containerizer_tests.cpp
<https://reviews.apache.org/r/29337/#comment114236>
3rd time similar code that can be factored out.
This is a fairly complex change. I will get back to it again, and make more comments then.
- Bernd Mathiske
On Jan. 16, 2015, 5:37 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29337/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 5:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Launch docker container and log through docker executor.
> Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 3ebbc1f
> src/docker/docker.cpp 3a485a2
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp b7bf54a
> src/slave/containerizer/docker.cpp 5f4b4ce
> src/tests/docker_containerizer_tests.cpp 2105ae2
>
> Diff: https://reviews.apache.org/r/29337/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Timothy Chen
>
>
Re: Review Request 29337: Launch docker container and log through
docker executor.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/
-----------------------------------------------------------
(Updated Jan. 17, 2015, 1:37 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Changes
-------
rebased.
Repository: mesos-git
Description
-------
Launch docker container and log through docker executor.
Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
Diffs (updated)
-----
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29337/diff/
Testing
-------
make check.
Thanks,
Timothy Chen
Re: Review Request 29337: Launch docker container and log through
docker executor.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/
-----------------------------------------------------------
(Updated Jan. 9, 2015, 1:25 a.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Changes
-------
Rebased
Repository: mesos-git
Description
-------
Launch docker container and log through docker executor.
Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
Diffs (updated)
-----
src/docker/docker.hpp 3ebbc1f
src/docker/docker.cpp 3a485a2
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp b7bf54a
src/slave/containerizer/docker.cpp 5f4b4ce
src/tests/docker_containerizer_tests.cpp 2105ae2
Diff: https://reviews.apache.org/r/29337/diff/
Testing
-------
make check.
Thanks,
Timothy Chen
Re: Review Request 29337: Launch docker container and log through
docker executor.
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/
-----------------------------------------------------------
(Updated Jan. 6, 2015, 10:18 p.m.)
Review request for mesos, Benjamin Hindman and Bernd Mathiske.
Repository: mesos-git
Description
-------
Launch docker container and log through docker executor.
Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
Diffs
-----
src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28
src/docker/docker.cpp 3a485a28d4b1ac3fcbce2e89c7d52b097886921a
src/docker/executor.cpp PRE-CREATION
src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815
src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e
Diff: https://reviews.apache.org/r/29337/diff/
Testing
-------
make check.
Thanks,
Timothy Chen
Re: Review Request 29337: Launch docker container and log through
docker executor.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29337/#review65847
-----------------------------------------------------------
Bad patch!
Reviews applied: [29327, 29328, 29329, 29330, 29331, 29332, 29333, 29334, 29335, 29336, 29337]
Failed command: ./support/apply-review.sh -n -r 29337
Error:
2014-12-23 00:01:32 URL:https://reviews.apache.org/r/29337/diff/raw/ [43123/43123] -> "29337.patch" [1]
error: patch failed: src/tests/docker_containerizer_tests.cpp:2581
error: src/tests/docker_containerizer_tests.cpp: patch does not apply
Failed to apply patch
- Mesos ReviewBot
On Dec. 22, 2014, 11:54 p.m., Timothy Chen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29337/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2014, 11:54 p.m.)
>
>
> Review request for mesos and Benjamin Hindman.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Launch docker container and log through docker executor.
> Also need to modify tests to wait for docker container to run after receiving TASK_RUNNING, since in the docker executor it launches the container non-detached, and we don't know when the container is actually running after the subprocess.
>
>
> Diffs
> -----
>
> src/docker/docker.hpp 3ebbc1f82ac388c4d348417ae33ccc2a56ad3f28
> src/docker/docker.cpp 3a485a28d4b1ac3fcbce2e89c7d52b097886921a
> src/docker/executor.cpp PRE-CREATION
> src/slave/containerizer/docker.hpp 28ebc6272cd68167fc9a0898fd8eb9d53890b815
> src/slave/containerizer/docker.cpp 19a6ea2b5342abe4bf10cf4ea2d5d756df9f8665
> src/tests/docker_containerizer_tests.cpp bed2d1005647d62b3ec013315b883d33990b896e
>
> Diff: https://reviews.apache.org/r/29337/diff/
>
>
> Testing
> -------
>
> make check.
>
>
> Thanks,
>
> Timothy Chen
>
>