[GitHub] [lucene-solr] dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost

[GitBox <gi...@apache.org>]

dsmiley commented on issue #357: [SOLR-12238] Synonym Queries boost
URL: https://github.com/apache/lucene-solr/pull/357#issuecomment-584817004
 
 
   @romseygeek can you approve the PR if your comments are addressed?  Looks good from my end.  I really appreciate your input on use of BoostAttribute -- I didn't know about that one!
   
   RE documentation: Yeah, I'm glad you are thinking of this; so many contributors (and sometimes us committers) don't.  I think there's a new TokenFilter you added here to document.  And then somewhere in synonym docs, some information suggesting how this can be used together.  I'd prefer you keep the ref guide changes minimally sufficient and leave the more wordy walk-through to a blog post and other mediums.  I'm looking forward to your blog post :-)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org