[incubator-trafficcontrol] 07/17: add basic unit test for roles.go

[mi...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

mitchell852 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-trafficcontrol.git

commit 6b762f036347184ee689e4bdb949937d43401cd1
Author: Dylan Volz <Dy...@comcast.com>
AuthorDate: Thu Apr 19 06:46:06 2018 -0600

    add basic unit test for roles.go
---
 traffic_ops/traffic_ops_golang/role/roles_test.go | 159 ++++++++++++++++++++++
 1 file changed, 159 insertions(+)

diff --git a/traffic_ops/traffic_ops_golang/role/roles_test.go b/traffic_ops/traffic_ops_golang/role/roles_test.go
new file mode 100644
index 0000000..44469ac
--- /dev/null
+++ b/traffic_ops/traffic_ops_golang/role/roles_test.go
@@ -0,0 +1,159 @@
+package role
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import (
+	"errors"
+	"reflect"
+	"strings"
+	"testing"
+
+	"github.com/apache/incubator-trafficcontrol/lib/go-tc/v13"
+	"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/api"
+	"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/auth"
+	"github.com/apache/incubator-trafficcontrol/traffic_ops/traffic_ops_golang/test"
+	"github.com/jmoiron/sqlx"
+
+	sqlmock "gopkg.in/DATA-DOG/go-sqlmock.v1"
+)
+
+func stringAddr(s string) *string {
+	return &s
+}
+func intAddr(i int) *int {
+	return &i
+}
+
+func getTestRoles() []v13.RoleNullable {
+	roles := []v13.RoleNullable{
+		{
+			ID:          intAddr(1),
+			Name:        stringAddr("role1"),
+			Description: stringAddr("the first role"),
+			PrivLevel:   intAddr(30),
+		},
+		{
+			ID:          intAddr(2),
+			Name:        stringAddr("role2"),
+			Description: stringAddr("the second role"),
+			PrivLevel:   intAddr(10),
+		},
+	}
+	return roles
+}
+
+func TestReadRoles(t *testing.T) {
+	mockDB, mock, err := sqlmock.New()
+	if err != nil {
+		t.Fatalf("an error '%s' was not expected when opening a stub database connection", err)
+	}
+	defer mockDB.Close()
+
+	db := sqlx.NewDb(mockDB, "sqlmock")
+	defer db.Close()
+
+	refType := GetRefType()
+
+	testRoles := getTestRoles()
+	cols := test.ColsFromStructByTag("db", v13.RoleNullable{})
+	rows := sqlmock.NewRows(cols)
+
+	for _, ts := range testRoles {
+		rows = rows.AddRow(
+			ts.ID,
+			ts.Name,
+			ts.Description,
+			ts.PrivLevel,
+		)
+	}
+	mock.ExpectQuery("SELECT").WillReturnRows(rows)
+	v := map[string]string{} //no selection criteria.
+
+	roles, errs, _ := refType.Read(db, v, auth.CurrentUser{})
+	if len(errs) > 0 {
+		t.Errorf("role.Read expected: no errors, actual: %v", errs)
+	}
+
+	if len(roles) != 2 {
+		t.Errorf("role.Read expected: len(roles) == 2, actual: %v", len(roles))
+	}
+}
+
+func TestFuncs(t *testing.T) {
+	if strings.Index(selectQuery(), "SELECT") != 0 {
+		t.Errorf("expected selectQuery to start with SELECT")
+	}
+	if strings.Index(insertQuery(), "INSERT") != 0 {
+		t.Errorf("expected insertQuery to start with INSERT")
+	}
+	if strings.Index(updateQuery(), "UPDATE") != 0 {
+		t.Errorf("expected updateQuery to start with UPDATE")
+	}
+	if strings.Index(deleteQuery(), "DELETE") != 0 {
+		t.Errorf("expected deleteQuery to start with DELETE")
+	}
+
+}
+func TestInterfaces(t *testing.T) {
+	var i interface{}
+	i = &TORole{}
+
+	if _, ok := i.(api.Creator); !ok {
+		t.Errorf("role must be creator")
+	}
+	if _, ok := i.(api.Reader); !ok {
+		t.Errorf("role must be reader")
+	}
+	if _, ok := i.(api.Updater); !ok {
+		t.Errorf("role must be updater")
+	}
+	if _, ok := i.(api.Deleter); !ok {
+		t.Errorf("role must be deleter")
+	}
+	if _, ok := i.(api.Identifier); !ok {
+		t.Errorf("role must be Identifier")
+	}
+}
+
+func TestValidate(t *testing.T) {
+	// invalid name, empty domainname
+	n := "not_a_valid_role"
+	r := TORole{Name: &n}
+	errs := test.SortErrors(r.Validate(nil))
+
+	expectedErrs := []error{
+		errors.New(`'description' cannot be blank`),
+		errors.New(`'privLevel' cannot be blank`),
+
+	}
+
+	if !reflect.DeepEqual(expectedErrs, errs) {
+		t.Errorf("expected %s, got %s", expectedErrs, errs)
+	}
+
+	//  name,  domainname both valid
+	r = TORole{Name: stringAddr("this is a valid name"), Description: stringAddr("this is a description"),PrivLevel:intAddr(30),}
+	expectedErrs = []error{}
+	errs = r.Validate(nil)
+	if !reflect.DeepEqual(expectedErrs, errs) {
+		t.Errorf("expected %s, got %s", expectedErrs, errs)
+	}
+
+}

-- 
To stop receiving notification emails like this one, please contact
mitchell852@apache.org.