You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/10/03 14:44:33 UTC

[GitHub] [zookeeper] ztzg opened a new pull request #1477: ZOOKEEPER-3951: C Client: Fix compilation with SASL disabled

ztzg opened a new pull request #1477:
URL: https://github.com/apache/zookeeper/pull/1477


   The `sasl_client` field doesn't exist when configured without SASL.  Use an accessor outside of the blocks already guarded by `HAVE_CYRUS_SASL_H`.
   
   (Reported by [Parag](https://issues.apache.org/jira/browse/ZOOKEEPER-3951).)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] asfgit closed pull request #1477: ZOOKEEPER-3951: C Client: Fix compilation with SASL disabled

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #1477:
URL: https://github.com/apache/zookeeper/pull/1477


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1477: ZOOKEEPER-3951: C Client: Fix compilation with SASL disabled

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1477:
URL: https://github.com/apache/zookeeper/pull/1477#issuecomment-703116025


   Thanks—though it would have been better to avoid it in the first place! :)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] ztzg commented on pull request #1477: ZOOKEEPER-3951: C Client: Fix compilation with SASL disabled

Posted by GitBox <gi...@apache.org>.
ztzg commented on pull request #1477:
URL: https://github.com/apache/zookeeper/pull/1477#issuecomment-706955278


   Yes, only `master`.  Many thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zookeeper] symat commented on pull request #1477: ZOOKEEPER-3951: C Client: Fix compilation with SASL disabled

Posted by GitBox <gi...@apache.org>.
symat commented on pull request #1477:
URL: https://github.com/apache/zookeeper/pull/1477#issuecomment-706902989


   I'll merge this. Master branch is enough here, right? (AFAICR SASL is not supported in3.6)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org