You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/11/28 17:18:57 UTC
[GitHub] [nuttx] Gary-Hobson opened a new pull request, #7726: drivers/segger: add channel 1/2 buffer configuration
Gary-Hobson opened a new pull request, #7726:
URL: https://github.com/apache/nuttx/pull/7726
## Summary
add channel 1/2 buffer configuration
## Impact
## Testing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] Gary-Hobson closed pull request #7726: drivers/segger: add channel 1/2 buffer configuration
Posted by GitBox <gi...@apache.org>.
Gary-Hobson closed pull request #7726: drivers/segger: add channel 1/2 buffer configuration
URL: https://github.com/apache/nuttx/pull/7726
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #7726: drivers/segger: add channel 1/2 buffer configuration
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7726:
URL: https://github.com/apache/nuttx/pull/7726#discussion_r1033841563
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
+ int "RTT channel 1 tx buffer size"
+ select SEGGER_RTT
Review Comment:
why select
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
+ int "RTT channel 1 tx buffer size"
+ select SEGGER_RTT
+ default 256
Review Comment:
let's add:
depends on SEGGER_RTT_MAX_NUM_UP_BUFFERS >= 1
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
+ int "RTT channel 1 tx buffer size"
+ select SEGGER_RTT
+ default 256
Review Comment:
```suggestion
default SEGGER_RTT_BUFFER_SIZE_UP
```
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
+ int "RTT channel 1 tx buffer size"
+ select SEGGER_RTT
+ default 256
+ ---help---
+ Size of the buffer for channel 1 output of target, up to host
+
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_DOWN
+ int "RTT channel 1 tx buffer size"
+ default 256
+ ---help---
+ Size of the buffer for channel 1 input to target from host
+
+config SEGGER_RTT_CHANNEL2_BUFFER_SIZE_UP
Review Comment:
who will use these new option? I don't see the code.
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
+ int "RTT channel 1 tx buffer size"
+ select SEGGER_RTT
+ default 256
+ ---help---
+ Size of the buffer for channel 1 output of target, up to host
+
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_DOWN
Review Comment:
apply the same change to all new option
##########
drivers/segger/Kconfig:
##########
@@ -63,6 +63,31 @@ config SEGGER_RTT_BUFFER_SIZE_DOWN
---help---
Size of the buffer for terminal input to target from host (Usually keyboard input)
+config SEGGER_RTT_CHANNEL1_BUFFER_SIZE_UP
Review Comment:
```suggestion
config SEGGER_RTT1_BUFFER_SIZE_UP
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org