You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "Chen768959 (via GitHub)" <gi...@apache.org> on 2024/09/01 13:34:19 UTC

[PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Chen768959 opened a new pull request, #40227:
URL: https://github.com/apache/doris/pull/40227

   When debugging in a Windows environment, the `jdbc_drivers_dir` format is `D:\xxx\xxx`. 
   The `getFullDriverUrl()` will return `file://D:\xxx\xxx`, which does not comply with URI format specifications and will prevent the JDBC jar from being loaded in Windows. 
   The correct FullDriverUrl format should be `file:///D:\xxx\xxx`.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "Chen768959 (via GitHub)" <gi...@apache.org>.
Chen768959 commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2324009484

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2343961211

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2323343040

   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
   
   Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
   See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "Chen768959 (via GitHub)" <gi...@apache.org>.
Chen768959 commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2336533582

   Could you please help review this? Thank you all. @morrySnow @xiaokang @dataroaring 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "morrySnow (via GitHub)" <gi...@apache.org>.
morrySnow commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2343958333

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40227: [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows
URL: https://github.com/apache/doris/pull/40227


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2343961282

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2324080869

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 38381 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 66e6feb72d6560b79ea0e8cf680ad18c3a195c0a, data reload: false
   
   ------ Round 1 ----------------------------------
   q1	17612	4473	4371	4371
   q2	2016	181	176	176
   q3	11824	999	1133	999
   q4	10711	675	720	675
   q5	7754	2818	2809	2809
   q6	231	139	138	138
   q7	970	618	602	602
   q8	9330	2098	2062	2062
   q9	7299	6606	6650	6606
   q10	7008	2178	2192	2178
   q11	448	237	241	237
   q12	414	233	236	233
   q13	20552	3164	3158	3158
   q14	277	242	235	235
   q15	531	490	494	490
   q16	594	515	502	502
   q17	990	710	766	710
   q18	7533	6815	6926	6815
   q19	1387	1110	1004	1004
   q20	664	338	341	338
   q21	4247	2960	3165	2960
   q22	1237	1083	1092	1083
   Total cold run time: 113629 ms
   Total hot run time: 38381 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   q1	4527	4474	4518	4474
   q2	394	284	282	282
   q3	3051	2896	2827	2827
   q4	2075	1818	1823	1818
   q5	5868	5816	5749	5749
   q6	242	143	150	143
   q7	2234	1849	1804	1804
   q8	3312	3513	3523	3513
   q9	8889	8837	8815	8815
   q10	3670	3357	3279	3279
   q11	615	507	528	507
   q12	850	655	696	655
   q13	15291	3303	3312	3303
   q14	329	305	293	293
   q15	542	498	512	498
   q16	659	596	568	568
   q17	1888	1589	1536	1536
   q18	8115	7849	7806	7806
   q19	1788	1606	1565	1565
   q20	2183	1872	1929	1872
   q21	5723	5483	5567	5483
   q22	1147	1092	1037	1037
   Total cold run time: 73392 ms
   Total hot run time: 57827 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2324106914

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 192576 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 66e6feb72d6560b79ea0e8cf680ad18c3a195c0a, data reload: false
   
   query1	1251	891	850	850
   query2	6450	2074	2040	2040
   query3	10670	3978	3927	3927
   query4	59811	25130	23072	23072
   query5	5465	517	498	498
   query6	422	170	160	160
   query7	5774	293	299	293
   query8	291	225	210	210
   query9	8891	2506	2477	2477
   query10	495	290	268	268
   query11	18113	15104	15525	15104
   query12	157	99	100	99
   query13	1531	418	385	385
   query14	11205	7549	7432	7432
   query15	225	184	186	184
   query16	7394	487	498	487
   query17	1111	591	569	569
   query18	1980	295	288	288
   query19	279	143	141	141
   query20	111	108	114	108
   query21	204	103	105	103
   query22	4841	4426	4539	4426
   query23	34399	33343	33438	33343
   query24	5909	2838	2817	2817
   query25	532	380	386	380
   query26	681	154	156	154
   query27	1785	285	284	284
   query28	3563	2056	2040	2040
   query29	670	401	406	401
   query30	238	154	160	154
   query31	896	763	745	745
   query32	79	53	52	52
   query33	460	274	275	274
   query34	860	469	476	469
   query35	840	707	747	707
   query36	1061	930	954	930
   query37	146	86	92	86
   query38	3995	3903	3953	3903
   query39	1445	1387	1418	1387
   query40	192	122	113	113
   query41	47	45	44	44
   query42	118	93	94	93
   query43	524	500	490	490
   query44	1092	738	737	737
   query45	203	173	174	173
   query46	1093	711	776	711
   query47	1950	1837	1766	1766
   query48	367	290	305	290
   query49	788	449	486	449
   query50	817	421	410	410
   query51	7272	7133	6921	6921
   query52	99	97	90	90
   query53	251	171	176	171
   query54	561	451	446	446
   query55	74	74	72	72
   query56	287	261	263	261
   query57	1199	1051	1045	1045
   query58	214	250	225	225
   query59	3169	2955	2786	2786
   query60	283	262	277	262
   query61	105	97	98	97
   query62	750	657	618	618
   query63	216	180	180	180
   query64	2832	722	659	659
   query65	3211	3145	3154	3145
   query66	640	341	337	337
   query67	15409	15282	15157	15157
   query68	2916	596	587	587
   query69	396	286	287	286
   query70	1149	1128	1065	1065
   query71	349	278	277	277
   query72	5372	4000	4006	4000
   query73	747	334	332	332
   query74	9132	8762	8802	8762
   query75	3328	2660	2688	2660
   query76	1338	957	944	944
   query77	552	332	386	332
   query78	9545	9071	9062	9062
   query79	1036	547	520	520
   query80	683	508	498	498
   query81	469	236	230	230
   query82	242	140	147	140
   query83	172	150	146	146
   query84	261	74	75	74
   query85	676	305	273	273
   query86	302	290	297	290
   query87	4405	4303	4357	4303
   query88	3191	2301	2314	2301
   query89	381	283	282	282
   query90	1941	186	188	186
   query91	124	98	98	98
   query92	60	51	50	50
   query93	1035	527	536	527
   query94	747	293	314	293
   query95	318	257	250	250
   query96	581	258	266	258
   query97	3185	3116	3102	3102
   query98	216	198	194	194
   query99	1533	1259	1286	1259
   Total cold run time: 304375 ms
   Total hot run time: 192576 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2324119217

   
   <details>
   <summary>ClickBench: <b>Total hot run time: 32.79 s</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
   ClickBench test result on commit 66e6feb72d6560b79ea0e8cf680ad18c3a195c0a, data reload: false
   
   query1	0.04	0.04	0.04
   query2	0.09	0.04	0.04
   query3	0.22	0.05	0.05
   query4	1.68	0.07	0.08
   query5	0.52	0.48	0.49
   query6	1.13	0.73	0.72
   query7	0.01	0.01	0.02
   query8	0.05	0.04	0.04
   query9	0.54	0.49	0.48
   query10	0.54	0.54	0.54
   query11	0.16	0.11	0.12
   query12	0.15	0.12	0.12
   query13	0.60	0.59	0.59
   query14	2.07	2.03	2.05
   query15	0.90	0.81	0.82
   query16	0.39	0.38	0.39
   query17	1.05	0.98	1.03
   query18	0.21	0.20	0.19
   query19	1.90	1.85	1.76
   query20	0.01	0.01	0.01
   query21	15.43	0.67	0.66
   query22	4.06	6.47	2.51
   query23	18.30	1.41	1.33
   query24	2.10	0.23	0.22
   query25	0.15	0.10	0.09
   query26	0.27	0.18	0.17
   query27	0.08	0.07	0.09
   query28	13.26	1.02	1.00
   query29	12.62	3.42	3.42
   query30	0.24	0.05	0.06
   query31	2.90	0.40	0.40
   query32	3.26	0.47	0.48
   query33	2.94	3.02	3.04
   query34	17.09	4.43	4.47
   query35	4.46	4.44	4.48
   query36	0.66	0.50	0.48
   query37	0.18	0.16	0.16
   query38	0.14	0.14	0.15
   query39	0.05	0.03	0.04
   query40	0.16	0.12	0.13
   query41	0.10	0.04	0.05
   query42	0.07	0.05	0.05
   query43	0.05	0.04	0.04
   Total cold run time: 110.83 s
   Total hot run time: 32.79 s
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] [fix](jdbc catalog) Fix incorrect format of FullDriverUrl under Windows [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40227:
URL: https://github.com/apache/doris/pull/40227#issuecomment-2712130504

   We're closing this PR because it hasn't been updated in a while.
   This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
   If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org