You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/09/09 13:39:45 UTC

[GitHub] [camel-quarkus] lburgazzoli opened a new pull request #1768: camel-quarkus-main - Uses reflection for setting its name

lburgazzoli opened a new pull request #1768:
URL: https://github.com/apache/camel-quarkus/pull/1768


   Fixes #1765


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton merged pull request #1768: camel-quarkus-main - Uses reflection for setting its name

Posted by GitBox <gi...@apache.org>.
jamesnetherton merged pull request #1768:
URL: https://github.com/apache/camel-quarkus/pull/1768


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] ppalaga commented on a change in pull request #1768: camel-quarkus-main - Uses reflection for setting its name

Posted by GitBox <gi...@apache.org>.
ppalaga commented on a change in pull request #1768:
URL: https://github.com/apache/camel-quarkus/pull/1768#discussion_r485632393



##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRegistryProcessor.java
##########
@@ -48,6 +49,21 @@ CamelRegistryBuildItem registry(CamelRecorder recorder) {
         return new CamelRegistryBuildItem(recorder.createRegistry());
     }
 
+    /*
+     * TODO: this is a workaround for https://github.com/apache/camel-quarkus/issues/1765

Review comment:
       Could you please file a follow up issue so that we do not forget?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] lburgazzoli commented on a change in pull request #1768: camel-quarkus-main - Uses reflection for setting its name

Posted by GitBox <gi...@apache.org>.
lburgazzoli commented on a change in pull request #1768:
URL: https://github.com/apache/camel-quarkus/pull/1768#discussion_r485633940



##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelRegistryProcessor.java
##########
@@ -48,6 +49,21 @@ CamelRegistryBuildItem registry(CamelRecorder recorder) {
         return new CamelRegistryBuildItem(recorder.createRegistry());
     }
 
+    /*
+     * TODO: this is a workaround for https://github.com/apache/camel-quarkus/issues/1765

Review comment:
       done already: https://github.com/apache/camel-quarkus/issues/1769




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [camel-quarkus] jamesnetherton commented on pull request #1768: camel-quarkus-main - Uses reflection for setting its name

Posted by GitBox <gi...@apache.org>.
jamesnetherton commented on pull request #1768:
URL: https://github.com/apache/camel-quarkus/pull/1768#issuecomment-689615089


   Test failure is unrelated to this change so merging this...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org