You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/10/12 02:29:09 UTC

[GitHub] [incubator-mxnet] yajiedesign opened a new pull request #19335: add windows cd scripts

yajiedesign opened a new pull request #19335:
URL: https://github.com/apache/incubator-mxnet/pull/19335


   ## Description ##
   add windows cd scripts
   
   ## Checklist ##
   ### Essentials ###
   - [x] Changes are complete (i.e. I finished coding on this PR)
   - [x] All changes have test coverage
   - [x] Code is well-documented
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] szha commented on a change in pull request #19335: add windows cd scripts

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19335:
URL: https://github.com/apache/incubator-mxnet/pull/19335#discussion_r503020798



##########
File path: tools/staticbuild/windows_cd/buildtool/mxnet-distro/doc/CU100MKL_ADDITIONAL.md
##########
@@ -0,0 +1,27 @@
+Prerequisites

Review comment:
       let's try to deduplicate these files by using the ones in the repo: https://github.com/apache/incubator-mxnet/blob/master/tools/pip/doc/CU102_ADDITIONAL.md




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] szha commented on a change in pull request #19335: add windows cd scripts

Posted by GitBox <gi...@apache.org>.
szha commented on a change in pull request #19335:
URL: https://github.com/apache/incubator-mxnet/pull/19335#discussion_r503020930



##########
File path: tools/staticbuild/windows_cd/buildtool/mxnet-distro/setup.py
##########
@@ -0,0 +1,201 @@
+# pylint: disable=invalid-name, exec-used

Review comment:
       https://github.com/apache/incubator-mxnet/blob/master/tools/pip/setup.py




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19335: add windows cd scripts

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19335:
URL: https://github.com/apache/incubator-mxnet/pull/19335#issuecomment-706820420


   Hey @yajiedesign , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, miscellaneous, windows-cpu, centos-cpu, unix-gpu, sanity, edge, clang, unix-cpu, windows-gpu, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org