[GitHub] [activemq-artemis] michaelandrepearce commented on a change in pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup

[GitBox <gi...@apache.org>]

michaelandrepearce commented on a change in pull request #2872: ARTEMIS-2531: Fix filter in FederatedQueue to prevent infinite consumer creation in a circular or bidrectional setup
URL: https://github.com/apache/activemq-artemis/pull/2872#discussion_r339188731
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/federation/queue/FederatedQueue.java
 ##########
 @@ -63,7 +63,7 @@ public FederatedQueue(Federation federation, FederationQueuePolicyConfiguration
       Objects.requireNonNull(config.getName());
       this.config = config;
       this.priorityAdjustment = federationUpstream.getPriorityAdjustment() + (config.getPriorityAdjustment() == null ? -1 : config.getPriorityAdjustment());
-      String metaDataFilterString = config.isIncludeFederated() ? null : FederatedQueueConsumer.FEDERATION_NAME +  " IS NOT NULL";
+      String metaDataFilterString = config.isIncludeFederated() ? null : "hyphenated_props:" + FederatedQueueConsumer.FEDERATION_NAME +  " IS NOT NULL";
 
 Review comment:
   It is meant to be circular in a directional setup, if theres a local consumer messages wont go back but should a message move to a broker and then consumer go then message should return back to first broker if there is one there

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services