You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/07/29 08:49:14 UTC

[GitHub] [pulsar] Nicklee007 commented on pull request #16806: Revert "Change ``rollCurrentLedgerIfFull`` logic to follow lazy creation of ledger (#14672)

Nicklee007 commented on PR #16806:
URL: https://github.com/apache/pulsar/pull/16806#issuecomment-1199032788

   > `testGetNumberOfEntriesInStorage` also failed. I think it's caused by the behavior change. BTW, we should verify the managed ledger's state, which should be `LedgerOpened` instead of `LedgerClosed`.
   
   @mattisonchao @BewareMyPower How about the PR #15474 has fix those unit test and achieve the same effect like revert.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org