You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by pengyanhong <gi...@git.apache.org> on 2014/07/26 17:18:12 UTC

[GitHub] spark pull request: add Kafka stream feature in according to speci...

GitHub user pengyanhong opened a pull request:

    https://github.com/apache/spark/pull/1602

    add Kafka stream feature in according to specified starting offset position to fetch messages

    create Kafka input  DStream to fetch batch messages from specified starting position

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pengyanhong/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1602.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1602
    
----
commit 618f6b766355d37dd91700ae3c48785981cf5bd9
Author: pengyanhong <pe...@sohu.com>
Date:   2014-07-24T15:07:30Z

    add Kafka stream feature in according to specified starting offset position to fetch messages

commit a6312058bc3bc6ea0998861f23593f2b2f0450b3
Author: pengyanhong <pe...@sohu.com>
Date:   2014-07-24T15:08:42Z

    add Kafka stream feature in according to specified starting offset position to fetch messages

commit 555038fd91ac9f92c0df0519d1407b948aa8737e
Author: pengyanhong <pe...@sohu.com>
Date:   2014-07-26T14:58:24Z

    refactor code

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-2803: add Kafka stream feature in accord...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/1602


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: add Kafka stream feature in according to speci...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:

    https://github.com/apache/spark/pull/1602#issuecomment-50237001
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] spark pull request: SPARK-2803: add Kafka stream feature in accord...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/1602#issuecomment-54694554
  
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: SPARK-2803: add Kafka stream feature in accord...

Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/1602#issuecomment-68079023
  
    @pengyanhong This is a very neat feature to add in Kafka utils. However, right now we are focused on improving fault-tolerance and semantic guarantees of the existing stream. This is not in our roadmap as of now. 
    
    However,  we have now added a new way for contributors to showcase their contributions to the community and maintain it themselves - spark-packages.org . Please consider adding your feature here. Others have done it too, e.g. http://spark-packages.org/package/5
    
    In the meantime, mind closing this PR?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request: add Kafka stream feature in according to speci...

Posted by tdas <gi...@git.apache.org>.
Github user tdas commented on the pull request:

    https://github.com/apache/spark/pull/1602#issuecomment-50690419
  
    @pengyanhong Can you please follow the usual process of creating a JIRA corresponding to this patch, and add the JIRA number to the title of PR? (See other PRs for reference)
    
    Also, particular to this patch, can you give some background behind this patch - what is the problem it is try to solve, what is the design of the solution? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---