[GitHub] [incubator-seatunnel] TyrantLucifer commented on a diff in pull request #2971: [Improve][Connector-V2] Improve text write

[GitBox <gi...@apache.org>]

TyrantLucifer commented on code in PR #2971:
URL: https://github.com/apache/incubator-seatunnel/pull/2971#discussion_r990787875


##########
seatunnel-e2e/seatunnel-spark-connector-v2-e2e/connector-file-spark-e2e/src/test/resources/file/fakesource_to_local_text.conf:
##########
@@ -54,12 +82,8 @@ sink {
     path="/tmp/test/text"
     field_delimiter="\t"
     row_delimiter="\n"
-    partition_by=["age"]
-    partition_dir_expression="${k0}=${v0}"
-    is_partition_field_write_in_file=true

Review Comment:
   These parameters are not applicable in this scenario. So I removed those. The core of the test is full type writing. What do you think about it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org