[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3927: ARTEMIS-3647 - OpenWire, remove rolledbackMessageRef on Ack

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #3927:
URL: https://github.com/apache/activemq-artemis/pull/3927#discussion_r801442248



##########
File path: artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/amq/AMQConsumer.java
##########
@@ -493,4 +495,10 @@ private boolean isRolledBack(MessageReference messageReference) {
       }
       return rollbackedMessageRefs.contains(messageReference);
    }
+
+   /** For tests only */
+   public Set<MessageReference> listRolledbackMessageRefs() {

Review comment:
       Also perhaps rather than make it public at all, make it package-private or protected and add a test-tree class in the same package as it to act as an accessor, e.g Clebert uses this approach, for an example (which just changes such a class) see https://github.com/apache/activemq-artemis/commit/2383aa0125320713b9a753668b203a878c24b2e0#diff-7426cf013ea833e8f1c3cd71cd26e9b584755e13d1fc4ccb4bc95025598795f6




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org