You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Bruno Borges (JIRA)" <ji...@apache.org> on 2008/10/21 22:48:44 UTC
[jira] Created: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
----------------------------------------------------------
Key: WICKET-1884
URL: https://issues.apache.org/jira/browse/WICKET-1884
Project: Wicket
Issue Type: Improvement
Components: wicket
Affects Versions: 1.4-M3
Reporter: Bruno Borges
Priority: Blocker
This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg reassigned WICKET-1884:
-------------------------------------
Assignee: Igor Vaynberg
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Blocker
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641596#action_12641596 ]
Bruno Borges commented on WICKET-1884:
--------------------------------------
Yes, I've replaced IMarkupResouceStreamProvider, but didn't think the same would work with IMarkupCacheKeyProvider.
The thing with IMarkupCacheKeyProvider is that it is just used to define a cache key for some container but it's not possible to _enforceLoad_ from there. The only place I found I can enforce load is from who calls loadMarkup.
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641601#action_12641601 ]
Igor Vaynberg commented on WICKET-1884:
---------------------------------------
if IMarkupCacheKeyProvider#getCacheKey() returns null then markup is never cached
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641592#action_12641592 ]
Igor Vaynberg commented on WICKET-1884:
---------------------------------------
sounds like you are not going about this right if you have to touch markup cache itself to support this.
have you seen IMarkupResouceStreamProvider and IMarkupCacheKeyProvider which components can implement to influence how their markup is loaded and cached?
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg updated WICKET-1884:
----------------------------------
Priority: Minor (was: Blocker)
i didnt realise an improvement can prevent everyone from using wicket...be careful with what you mark as a blocker!
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641587#action_12641587 ]
Igor Vaynberg commented on WICKET-1884:
---------------------------------------
what is your specific usecase for this?
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641590#action_12641590 ]
Bruno Borges commented on WICKET-1884:
--------------------------------------
Sorry Igor, my bad.
I'm developing a way to provide somehow XStream-integrated components. Like XStreamMarkupContainer, and I ended having to override MarkupCache. From there, I want it to not cache XStream's generated XMLs.
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Igor Vaynberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Vaynberg resolved WICKET-1884.
-----------------------------------
Resolution: Won't Fix
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-1884) Remove 'final' from
InheritedMarkupMarkupLoader#loadMarkup
Posted by "Bruno Borges (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-1884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12641602#action_12641602 ]
Bruno Borges commented on WICKET-1884:
--------------------------------------
Please ignore this issue. VelocityPanel seems to have all the answers.
> Remove 'final' from InheritedMarkupMarkupLoader#loadMarkup
> ----------------------------------------------------------
>
> Key: WICKET-1884
> URL: https://issues.apache.org/jira/browse/WICKET-1884
> Project: Wicket
> Issue Type: Improvement
> Components: wicket
> Affects Versions: 1.4-M3
> Reporter: Bruno Borges
> Assignee: Igor Vaynberg
> Priority: Minor
>
> This class is public and it would be useful to extend it, but seems non-sense since loadMarkup is final.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.