You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by "Divij Vaidya (Jira)" <ji...@apache.org> on 2020/09/27 19:36:00 UTC

[jira] [Commented] (TINKERPOP-2426) Use Netty's WebSocketClientProtocolHandler

    [ https://issues.apache.org/jira/browse/TINKERPOP-2426?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17202918#comment-17202918 ] 

Divij Vaidya commented on TINKERPOP-2426:
-----------------------------------------

PR: https://github.com/apache/tinkerpop/pull/1335

> Use Netty's WebSocketClientProtocolHandler
> ------------------------------------------
>
>                 Key: TINKERPOP-2426
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2426
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: driver
>    Affects Versions: 3.5.0, 3.4.8
>            Reporter: Divij Vaidya
>            Priority: Minor
>
> Code can be simplified by using Netty's [WebSocketClientProtocolHandler|https://netty.io/4.1/api/io/netty/handler/codec/http/websocketx/WebSocketClientProtocolHandler.html] instead of writing a custom implementation at [WebSocketClientHandler|https://github.com/apache/tinkerpop/blob/3.4-dev/gremlin-driver/src/main/java/org/apache/tinkerpop/gremlin/driver/handler/WebSocketClientHandler.java]
>  
> The motivation of this ticket is to replace the latter with the former.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)