[GitHub] [zookeeper] symat commented on a change in pull request #1266: ZOOKEEPER-3721: Making the boolean configuration parameters consistent

[GitBox <gi...@apache.org>]

symat commented on a change in pull request #1266:
URL: https://github.com/apache/zookeeper/pull/1266#discussion_r422811615



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeerConfig.java
##########
@@ -969,4 +953,15 @@ public static void setReconfigEnabled(boolean enabled) {
         reconfigEnabled = enabled;
     }
 
+    private boolean parseBoolean(String value) throws ConfigException {
+        if (value.equalsIgnoreCase("true")) {
+            return true;
+        } else if (value.equalsIgnoreCase("false")) {
+            return false;
+        } else {
+            throw new ConfigException("Invalid option "

Review comment:
       please also log the parameter name, helping the users to find out which config is wrong.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org