[maven-bug] New comment: (MAVEN-308) Checkstyle plugin can throw an OutOfMemory exception

[bo...@werken.com]

The following comment has been added to this issue:

     Author: Tim O'Brien
    Created: Sun, 2 Mar 2003 11:51 PM
       Body:
Sorry, that was "oburn" not "oburns"
---------------------------------------------------------------------
View the issue:

  http://jira.werken.com/secure/ViewIssue.jspa?key=MAVEN-308


Here is an overview of the issue:
---------------------------------------------------------------------
        Key: MAVEN-308
    Summary: Checkstyle plugin can throw an OutOfMemory exception
       Type: Bug

     Status: Assigned
   Priority: Minor

 Time Spent: Unknown
   Estimate: 0 minutes

    Project: maven
  Component: None
   Versions:
             1.0-beta-9

   Assignee: Jason van Zyl
   Reporter: Tim O'Brien

    Created: Sun, 2 Mar 2003 11:47 PM
    Updated: Sun, 2 Mar 2003 11:47 PM

Description:
Trying to run checkstyle against code that does compile can cause an OutOfMemory exception.  For projects that happen to have code that doesn't compile, the causes site:generate to fail.

Sure, this is an exceptional condition.  Projects shouldn't be running around with code that doesn't compile, but what are issue tracking systems for if not for people to find exceptional conditions and enter them in.  In other words, this may not be a bug, but from my perspective anything that causes a Maven user to see an OutOfMemoryException is interesting enough to put into Jira.

The offending code was this:

        if (!(pObject instanceof java.lang.String)) {
            throw new EncoderException("Parameter supplied to " 
                                       + "Soundex " 
                                       + "encode is not of type " 
                                       " "java.lang.String"); 
        } 

You'll note that there is a " instead of the final + operator.

I opened a bug on checkstyle's SourceForge site, and oburns replied that checkstyle expects compilable code for input.  Should the pluing verify that the code can compile by calling javac or something?


---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://jira.werken.com/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira