You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/19 10:32:08 UTC

[GitHub] [airflow] ashb commented on a change in pull request #14869: Fixed autocommit calls for mysql-connector-python

ashb commented on a change in pull request #14869:
URL: https://github.com/apache/airflow/pull/14869#discussion_r597566030



##########
File path: airflow/providers/mysql/hooks/mysql.py
##########
@@ -52,7 +52,10 @@ def __init__(self, *args, **kwargs) -> None:
 
     def set_autocommit(self, conn: Connection, autocommit: bool) -> None:  # noqa: D403

Review comment:
       Generally: one of the biggest slow downs in Airflow "boot" time is importing modules, so avoiding top level imports where it's not strictly needed is better I think.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org